Git Product home page Git Product logo

editable-plugin's People

Contributors

acasar avatar blazorazem avatar cggstudio avatar daftspunk avatar gergo85 avatar luketowers avatar mahony0 avatar nnmer avatar vojtasvoboda avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

editable-plugin's Issues

Suggestion: the editor should display the actual md file when editing .md block, not the rendered html

I am using Markdown in content block and the editable plug-in so I only have to edit chunks of text when I need to update information.

But having the md chunk rendered to html tags in the source code of the editor breaks that workflow and purpose since I have to type in a soup tag.

Could the editor load the md file without rendering it to html and leave it as it is ?

The current workaround I found is to convert .md files to .htm and use the wysywig editor but I don't want some users to mess with tags (even in the wysywig editor).

TypeError: $.request not a function

Hello,

I've got editable mostly working but It seems to want to throw the following error on save.

TypeErrror: $.request is not a function on editable.js line 76

Could you help point me in the right direction for getting this saving correctly?

Are there other dependencies that we might need to get this working? A certain version of jquery, or could particular versions of jquery included in my layout conflict with this?

URL Changes when language is changed using translate plugin

Dear Team,

Thank you for the wonderful plugin. This has helped us a lot in handling partials like a charm. But the issue we are facing is when we add the rainlab translate plugin. Below are the screenshots showing some the issues pertaining when we translate to Chinese language. The URL of the editable file changes with the extension of zh-hans (as shown in the screenshots). Kindly help us in rectifying the issue or correct us we we are doing something wrong.

image

image

image

Best Regards.
Vijay Patel

Ability to use the media library

Please add the ability to use the media library from the frontend of the site. Adding media elements is only possible using the backend which defeats the purpose of this plugin. I think this would be a really useful addition to the plugin. Thanks!

[Suggestion] "move-up" transform issues

This might only be an issue for me, but when I'm trying to edit a content, it takes a good few number of tries to click on the .editable-edit-button due to the transform. It's constantly resetting & re-running the transform making it hard to actually click on the button. It seems as though the button is behind the content, so if any content runs the full width of the container, it's hard to catch the button.

Like I said, this could just be an issue for me, and I'm happy to comment out the CSS in the plugin to disable it myself, but just wondering if anyone else has this issue?

Component Failure after update to build 151

Getting error : Call to a member function parseMarkup() on a non-object in \modules\cms\classes\Content.php line 41 after updating to version 151 of October.....
--Edit--
This appears to be an issue with content parsing in build 151... And not necessarily the plugin

Editable and translator plugin

If translate plugin installed, editable plugin doesn't follows the right "locale file". It dosen't check that = suffix at all.

JS error when interacting with the toolbar

Hi everyone, someone had this error before? Everytime I interact with the redactor component, specially clicking the toolbar options this error appears.

I've added in the layout the {% framework %}, {% scripts %} and {% styles %} tags. What im doing wrong?

ss 2016-09-20 at 04 12 54

ss 2016-09-20 at 04 20 44

ss 2016-09-20 at 04 21 30

Getting empty content

Hi!

On line https://github.com/rainlab/editable-plugin/blob/master/assets/js/editable.js#L100 when getting the code of the component it returns an empty string.

Then, when clicking on the Cancel button it does not set the content to its old version.

While debugging the redactor plugin on line https://github.com/octobercms/october/blob/master/modules/backend/formwidgets/richeditor/assets/vendor/redactor/redactor.js#L2891 it makes two calls to the code.get method, first one returns a empty string and immediately thereafter it returns the real content.

Compatibility with bootstrap modal

When editing content that is inside bootstrap modal, editable plugin removes every single div that have class"modal". Is this normal plugin behaviour or Its a bug?

Plugin Easily Runs Into CSS Problems Due To Generic Class Names

EDIT: The classes .visible and .active are very general and will easily be overridden if used in the site's css at all. Either on the element that editable is used on (which happened in my case), or if used as a global class. A suggestion to the plugin dev would be to use classes specific to the plugin name like .editable-visible and .editable-active instead.

This would prevent this problem from ever happening in the future as it's a pretty understandable mixup that I encountered.

When I first installed OctoberCMS about a month ago, this plugin was working flawlessly. After updating the build somewhat recently, I noticed that the plugin no longer works. When I hover over the editable text on the front-end, it resizes the scrollbar as if it's trying to do something, but nothing happens.

All of the proper resources are loading, jquery.js & editable.js as can be seen here:

Proper resources are loading

Not sure what's going on though. Anyone else encountering this problem? Such an essential plugin for my clients to edit their site content.

Thanks!

ETA?

No issue, just very much looking forward to using this plugin :P

Any chance we'll see it on the plugins page soon?

I18N and L10N

I'm developing E-commerce system with October and using this plugin. If you can add lang folder and make texts and inputs dynamic -takes only 5-10 mins.- this plugin will be very useful for me and others. I can help editing the plugin btw. Thanks.

Error in console when editing

Hi Sam, I'm now getting this error in the console when trying to edit a content:

Uncaught Error: No such method "get" for Redactor 

Disappearing div and span

I'm afraid we have an issue with whatever is inside a div, somehow some tags are disappearing.

If we edit this HTML by just removing the comma:

<div class="title">
    <h3>Mangiare, è incorporare un territorio. <br /> <span>Jean Brunhes</span></h3>
    <div class="line"></div>
</div>

it will be saved as:

<h3>Mangiare è incorporare un territorio. <br> Jean Brunhes</h3>

Is there a way to be keep all the tags and just change the inner text of them?

May be related to #40

Allow user to edit if has the rainlab.pages.manage_content permission

I have an user without cms.manage_content permission, but with rainlab.pages.manage_content enabled. I managed to solve it with this change:

   public function checkEditor()
    {
        $backendUser = BackendAuth::getUser();
        return $backendUser && ($backendUser->hasAccess('cms.manage_content') || $backendUser->hasAccess('rainlab.pages.manage_content'));
    }

Sorry don't have the time to do a pull request now, in nobody takes care I will do it when I can!

Not working in partials (AJAX handler not found error)

If an editable is added to a partial, once the user tries to save changes to that content the browser throws an error: AJAX handler 'editable:onSave' was not found.

Same editable works fine in a regular page.

Any suggestions would be much appreciated.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.