raimannma / valorantapi Goto Github PK

Hi everyone,

Not sure if it is a bug report or a limitation of the RIOT API, but I will put it as a bug report.

🐛 Bug Report

It seems only the last 10 match in Match History can be accessed when using valo_api.endpoints.get_match_history_by_name_v3.

🔬 How To Reproduce

Steps to reproduce the behavior:

Use size >= 10 in function, only the last 10 matches are retrieved.

Code sample

Called valo_api.endpoints.get_match_history_by_name_v3([REGION], [PLAYER], [TAG], size=100)

Environment

• OS: Linux
• Python version, get it with: 3.8.10

📈 Expected behavior

In other trackers online they seem to have more matches available, so I would guess those information are still RIOT database and should be accessible through the API?

Thanks you for your help and for the library!

🐛 Bug Report

When calling the method get_match_history_by_puuid_v3 we now get an exception.

🔬 How To Reproduce

Steps to reproduce the behavior:

Code sample

  File "C:\Users\ander\Documents\repos\valstats\valstats.py", line 190, in get_game_history
    response = valo_api.get_match_history_by_puuid_v3(region=auth.region, puuid=user_id, size=10, game_mode=typ)
  File "C:\Users\ander\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\valo_api\endpoint.py", line 88, in wrapper
    return self._get_endpoint(*args, **kwargs)
  File "C:\Users\ander\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\valo_api\endpoint.py", line 154, in _get_endpoint
    return self.parse_response(response, response.content)
  File "C:\Users\ander\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\valo_api\endpoint.py", line 179, in parse_response
    result = msgspec.json.decode(content, type=return_type)
msgspec.ValidationError: Expected `int`, got `float` - at `$.data[0].players.all_players[0].economy.spent.average

Environment

Python 3.11.9
valo_api==2.0.7

Screenshots

📈 Expected behavior

The call should succeed and return the same payload as before.

📎 Additional context

This used to work a couple of weeks ago. It seems the returned payload has changed format.

Using msgspec json decode is much faster than using the InitOptions class.

Should be easy to replace.