railsmechanic / bankster Goto Github PK

View Code? Open in Web Editor NEW

30.0 3.0 10.0 54 KB

An IBAN account numbers and BIC validation tool for Elixir.

Home Page: https://hex.pm/packages/bankster

License: MIT License

Elixir 100.00%

iban banking elixir validate-bics

bankster's People

Contributors

Stargazers

Watchers

Forkers

jshmrtn socialpaymentsbv jarroput ktp-forked-repos atlas-forks kirillshamardin rafaeltheraven m1dnight warmwaffles

bankster's Issues

Does not support new IBAN countries (e.g. PK - Pakistan)

Example valid IBAN number taken from IBAN.com: PK36SCBL0000001123456702 is said by Bankster to be invalid:

iex(13)> Bankster.Iban.valid?("PK36SCBL0000001123456702")                                                                                                           
false
iex(14)> Bankster.Iban.validate("PK36SCBL0000001123456702")
{:error, :invalid_country}

Stumbled upon when using Bankster together with Faker (Faker.Code.iban).

Add functions on supported countries

Add a function which returns all supported country codes
Add a function which validates whether a country is supported

"&&" in the IBAN checksum causes exception in validation

iex(3)> Bankster.Iban.validate("PK36SCBL0000001123456702")
{:ok, "PK36SCBL0000001123456702"}
iex(4)> Bankster.Iban.validate("PK33SCBL0000001123456702")
{:error, :invalid_checksum}
iex(5)> Bankster.Iban.validate("PK&&SCBL0000001123456702")
** (ArgumentError) argument error
    :erlang.binary_to_integer("2812112100000011234567022520&&")
    (bankster) lib/bankster/iban.ex:301: Bankster.Iban.iban_violates_checksum?/1
    (bankster) lib/bankster/iban.ex:246: Bankster.Iban.validate/1

The IBAN format validation should catch this.

Function for returning the country code should validate

The function which returns the country code for a given IBAN should check whether the given country code of the IBAN is within the list of supported countries:

bankster/lib/bankster/iban.ex

Lines 187 to 191 in 1572aaf

 def country_code(iban) do 

 iban 

 |> format_default() 

 |> String.slice(0..1) 

 end

Change from returning a simple string to
{:ok, "DE"} or {:error, :invalid_country}

This is a breaking change!

[Be Aware] Wrong IBAN Validations

Use the test IBANs from https://www.iban.com/testibans, I noticed that the library is not validating IBAN correctly.

     invalid_ibans = ~w(
        GB94BARC20201530093459
        GB96BARC202015300934591
        GB02BARC20201530093451
        GB68CITI18500483515538
        GB24BARC20201630093459
        GB12BARC20201530093A59
        GB78BARCO0201530093459
        GB2LABBY09012857201707
        GB01BARC20714583608387
        GB00HLFX11016111455365
        US64SVBKUS6S3300958879
      )

      Enum.each(invalid_ibans, fn iban ->
        iban
        |> Bankster.iban_validate()
        |> IO.inspect()
      end)

{:error, :invalid_checksum}
{:error, :invalid_length}
{:ok, "GB02BARC20201530093451"}
{:ok, "GB68CITI18500483515538"}
{:ok, "GB24BARC20201630093459"}
{:error, :invalid_format}
{:error, :invalid_format}
{:ok, "GB2LABBY09012857201707"}
{:ok, "GB01BARC20714583608387"}
{:ok, "GB00HLFX11016111455365"}
{:error, :invalid_country}

railsmechanic / bankster Goto Github PK

bankster's People

Contributors

Stargazers

Watchers

Forkers

bankster's Issues

Does not support new IBAN countries (e.g. PK - Pakistan)

Add functions on supported countries

"&&" in the IBAN checksum causes exception in validation

Function for returning the country code should validate

[Be Aware] Wrong IBAN Validations

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	def country_code(iban) do
	iban
	\|> format_default()
	\|> String.slice(0..1)
	end