raganwald / jquery-combinators Goto Github PK

http://news.ycombinator.com/item?id=1450178

See http://blog.jquery.com/2011/12/08/what-is-happening-to-the-jquery-plugins-site/ and https://github.com/jquery/plugins.jquery.com/blob/master/docs/package.md

I know this plugin is very simple but I just did some refactoring (#12) and couldn't test if I broke something or not.

Changing the code to allow multiple arguments removed the ability to pass the current collection as the first argument. This is still functional, of course, as the pseudo-variable this will refer to the current collection. However, this conflicts with the examples in the docs, which use a parameter.

The other problem with the "new" functionality is that it makes refactoring slightly harder. If you already have a function that takes a selection as a parameter, you have to replace all of its parameter references with "this." With the old functionality, you could use the function as-is.

The correct functionality should be that if you pass parameters, the first parameter should be the current selection and the remaining parameters should be fixed. This should be documented.