Git Product home page Git Product logo

Comments (8)

michaelklishin avatar michaelklishin commented on July 30, 2024

@mheidt this is open source software. If you need something, please submit a PR

from hop.

acogoluegnes avatar acogoluegnes commented on July 30, 2024

The consumers endpoint does not support pagination and I don't think it supports filtering by name/regex.

from hop.

mheidt avatar mheidt commented on July 30, 2024

I know. that's why I closed it. I thought, the people behind this are in contact with the people of the real API as well.

from hop.

mheidt avatar mheidt commented on July 30, 2024

@michaelklishin
It seems, that we have a major issue with this call.
Our productive rabbit has a shovel defined and those connections look like
{
"arguments": {},
"ack_required": true,
"active": true,
"activity_status": "up",
"channel_details": {
"connection_name": "[email protected]",
"name": "[email protected] (1)",
"node": "rabbit@10-244-108-91",
"number": 1,
"peer_host": "undefined",
"peer_port": "undefined",
"user": "shovel"
},
"consumer_tag": "amq.ctag-uLSmF70x9pQEDL34OCbkvg",
"exclusive": false,
"prefetch_count": 1000,
"queue": {
"name": "amq.gen-vIuezFJTmuEAOB2SouuafQ",
"vhost": "PROD"
}
},

The peer_port yields to
JSON parse error: Cannot deserialize value of type int from String "undefined": not a valid Integer value;

Should I make a PR, that is making ChannelDetails.peerPort a String?

from hop.

mheidt avatar mheidt commented on July 30, 2024

Of course nicer would be if the API (not hop) would support the filter...

from hop.

Guzzi avatar Guzzi commented on July 30, 2024

@michaelklishin: Alternatively (and not breaking the http API) it might be possible to fix this in the shovel plugin, so that either a real portnumber or "0" is set for unknown port in peer_port !?

from hop.

acogoluegnes avatar acogoluegnes commented on July 30, 2024

The management API should fix the issue, maybe a proper default value would be 0 or -1, I don't know if this happens in other cases. It's also weird the values are not set.

This should also be fixed in Hop, in case the client is used with broker versions without the fix. I'd say the simplest is to use a custom deserializer that handles the undefined value. We cannot change the type, it would be a breaking change.

from hop.

acogoluegnes avatar acogoluegnes commented on July 30, 2024

Closed in favor of #248.

from hop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.