Provide more information in case of error about hop HOT 7 CLOSED

Server logs would contain a very specific message when authentication fails.

Since every response in theory has access to the HTTP context, changing the API to include it makes some sense.
How many changes this would require given a specific HTTP client, I cannot immediately tell.

from hop.

I'll give a try because it's easy to test, but more information would be welcome: Hop version, a code snippet to reproduce (to find out which HTTP layer is used). Without this it's difficult to diagnose the problem. Thanks.

from hop.

The (default) HttpClient layer introduced in 4.0 would not handle errors properly for GET requests, I pushed a couple of changes to fix this. This is likely what you're were experiencing, but I'll wait your confirmation before releasing 4.1.

from hop.

Thanks for your reply and fixes. I'll get back to you next week.

from hop.

@acogoluegnes I've tested the authentication error and I can confirm that it's handled much better now.
I've also tested getting a non-existing queue and in this case I get null in return. From your commit, I see that the 404 code is handled specifically to return null but I'm wondering why. As a user I would have found it more helpful to have the exception with the status code like the other codes.

from hop.

Thanks for testing.

Returning null for non-existing resources is a historical design decision in Hop that was made before I started working on the library. Maybe @michaelklishin has more information about this.

I don't think it'll be easy to change this now, as it would be a significant breaking change.

from hop.

Ok I see, well it's not a big deal but something to be aware of to avoid NullPointerExceptions.

from hop.