Naming conflicts for cportables. about raaz HOT 3 CLOSED

We can use some namespace trick but as far as I know C doesn't support namespace like c++.

from raaz.

define has global namespace so I dont know how to fix that.

from raaz.

On Mon, Jul 29, 2013 at 05:02:18AM -0700, satvikc wrote:

I was trying to implement sha256 cportable version and ended into naming conflicts

/usr/bin/gcc returned ExitFailure 1 with error message:
In file included from /tmp/19611.c:2:0:
cbits/raaz/hash/sha256/portable.h:26:14: error: conflicting types for ‘Hash’
typedef Word Hash [ HASH_SIZE ];
^
In file included from /tmp/19611.c:1:0:
cbits/raaz/hash/sha1/portable.h:26:14: note: previous declaration of ‘Hash’
was here
typedef Word Hash [ HASH_SIZE ];
^
cabal: Bad header file: raaz/hash/sha256/portable.h

We should change the naming to be more consistent with the hash it is implementing.

I did not think that the typedefs would clash. Yes we should change
the names. Here are few possibilities

1. Change it to

typedef uint32_t SHA1Word;
typedef SHA1Word SHA1HASH[ HASH_SIZE ];

This will avoid clash with other typedefs in raaz packages. However,
if some other package depends on raaz and has a separate routine for
sha then there is a possibility of clash. I remember that yesod and
darcs library chashed because there was a sha1 implementation in darcs
which clashed with that of crypto packages used by yesod.

This means prefixing an extra Raaz on to every thing. That kills the
goodness of the typedef.

1. Use # defines instead of typedefs. This will not clash as it is
   macro substituted. However, I hate this.

We need to discuss this issue in detail.

from raaz.