r-park / todo-redux-saga Goto Github PK

Could you explain to me the 10th line of code? I can't figure out why we must use an array here. Thank you.

Would you consider replacing the build scripts with kyt or is there any specific need that is unmet? https://github.com/NYTimes/kyt

Hi there,

Great repo, thanks for your effort on this.
I want to deploy my application to heroku instead of firebase. However I am not able to run start script after deployement. Any chance you may know what I may be missing? Npm run build && npm run server should do the trick or?

Thanks,
Arda

Hey, first off, thank you so much for this example (as well as the other redux/firebase w/o sagas example). They seem to be a near perfect example on getting a basic/standard firebase setup inside a React/Redux project (you probably saved me days of effort just on the firebase code.... then the saga code, with a version without sagas for reference is amazing). While by no means critical, it may be worth making the 2 more consistent (ie. same action constants).

Anyway, aside from thanking you, I definitely want to pick your brain on a few things... in some cases it's hard to figure out if you are doing something in a specific way just because this example is concentrating on demoing other features and you just didn't care about certain parts... or if there are specific reasons for parts of the code.

One question I have is, is there a reason you are using history.push instead of react-router-redux's push action?

Also, is firebase-list.js based off of some other example/project.. or is it completely custom for these examples? (either way THANK YOU, it's a great piece of code I have already stolen)

Thanks in advance, and sorry for creating an issue for my questions... but I figure this being a demo repo, the issue won't be cluttering up more important ones.

Hey @r-park love this example. I've applied this example's logic to a more complex firebase structure with denormalized entries.

How would you recommend building a firebase model that can support lists of objects like this?

{
  "some-list" : {
    "-KbgyM0uO2l9oHCDwzAq" : {
      "prop" : "great",
      "some-ids" : {
        "-KbgyM-bzdBprmzIePhp" : true,
        "-KbwQ_AiyQcagPHnoEeI" : true
      },
      "other-ids" : {
        "again" : true,
        "nice" : true,
        "try" : true,
        "word" : true
      }
    },
    "-KbhA_tJ9ZyqQVzwHwWT" : {
      "item" : "fun",
      "some-ids" : {
        "-KbhA_sCvTVPBaFBRYcL" : true,
        "-KbwIevJI96eLSBP9h3b" : true
      },
      "other-ids" : {
        "again" : true,
        "new" : true,
        "nice" : true,
        "try" : true
      }
    }
  }
}

The existing firebase-list works really well for a list of simple objects, but is a little clunky for lists with other simple lists nested inside. Maybe some sort of composable model structure? I've also looked at firebase-saga which takes a more functional approach, although, I like being able to set the class properties in the watchers.

I'm a little torn on how to proceed. What do you recommend for more complex, denormalized structures?