qutech / qopt Goto Github PK

I found it confusing, that the index property of CostFunction is a human readable string.

Is there a reason why Spyder is a dependency? In my experience, it causes trouble when installing (even if Spyder is already installed).

The function to_dict() of OptimizationResult stores the variable final_parameters under the key final_amps. Therefore, I get an error message when rehydrating the object again:

result = optimizer.run_optimization(initial_control_amplitudes=initial_pulse)
OptimizationResult.from_dict(result.to_dict())

leads to the error TypeError: __init__() got an unexpected keyword argument 'final_amps'

Currently DenseOperator's __repr__ method simply forwards the call to the underlying ndarray. This can obscure the data type in a REPL workflow since printing the DenseOperator will not tell the user that it is actually a DenseOperator.

I suggest adding a bit of information along the lines of a QuTiP Qobj:

Quantum object: dims = [[2], [2]], shape = (2, 2), type = oper, isherm = False
Qobj data =
[[0. 0.]
 [1. 0.]]

So maybe something like this:

def __repr__(self):
    s = 'DenseOperator with data\n' + str(self.data)

In the documentation examples the package qopt.examples.rabi_driving is used, but it is not part of qopt.

@JDTeske