quickrelease / qr-hooks Goto Github PK

When applying this hook to repos that have auto named migrations that have already been applied to production databases, it will always fail but we can't rename them. In other cases _auto_ may be a component of an explicitly named migration.

The main issue is when an old migration is reformatted by black, say, and then it cannot be committed without failing this check.

--no-verify can be used, but GitHub workflows running all pre-commit hooks will fail it.

Possible solution is to maintain a list of files to ignore, either in the config (but this would get ugly fast), or in a separate file (but then we have yet another file).

Using the number prefix of the migration could used to specify ranges, e.g.

exclude:
  - app1: <0023
  - app2: 0054

The check currently fails for url(r"^$", ...) but doesn't for path("", ...), when these are effectively equivalent. In both cases, this is correct, and having an additional slash would be wrong.
More importantly, it fails for url(r"^media/(?P<path>.*)", ...) which does not need to end in a slash because of the .* at the end. In cases where that path is empty, the URL will already end in a slash.