quickrelease / django-async-downloads Goto Github PK

Raise exception if download was removed from cache during download process (user click to clear download, during uncompleted process).

Exception will be raised depend on function new keyword argument.

Thanks to that celery tasks will be killed instantly.

If the JS is packaged and available on npm with appropriate module exports, then it can be webpacked when included in other projects. This would also require that templates do not rely on global scope for function definitions (e.g. downloads.html calls clearDownload).

When the large file is saved.
The bug does not appear on v 0.3.0 and below.

We think that (this probably occurs when the max_size has been reached) bytes remaining in the buffer do not get saved into the temp_file.

Possible solution is to force remaining bytes into the rawstream by calling temp_file.flush() before line 89 in async_downloads/cache.py

    writer = csv.writer(temp_file, lineterminator="\n")
    for row in iterable:
        writer.writerow(row)
    temp_file.flush()
    default_storage.save(download["filepath"], temp_file._file.buffer)

https://github.com/QuickRelease/qronos/pull/1145/