Git Product home page Git Product logo

quickfixj-orchestra's People

Contributors

chrjohn avatar david-gibbs-ig avatar donmendelson avatar jacobnorthey-itiviti avatar onurkaraduman avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

david-gibbs-ig davidchen-tp

quickfixj-orchestra's Issues

Errors with generated code for `UTCDateOnly` 

          > I have errors like this when building with `full-fix-latest`.

ComplexEventStartDate.java:[22,16] error: incompatible types: String cannot be converted to LocalDate

Any idea what might be wrong? Was this related to the changes you did here: quickfix-j/quickfixj-orchestra#4 ?

@david-gibbs-ig , I think I know where this error comes from. All fields that have a type of UTCDateOnly are affected by this. The reason seems to be these lines of code that I think were added by you. Do you still recall why we need an extra constructor with String?

quickfixj-orchestra/quickfixj-from-fix-orchestra-repository/quickfixj-from-fix-orchestra-generator/src/main/java/org/quickfixj/orchestra/CodeGeneratorJ.java

Lines 858 to 860 in 1845c43

// added for compatibility with existing QFJ tests
writer.write(String.format("%n%spublic %s(String data) {%n%ssuper(%d, data);%n%s}%n", CodeGeneratorUtil.indent(1), className,
CodeGeneratorUtil.indent(2), fieldId, CodeGeneratorUtil.indent(1)));

You did some (related ?) changes with this PR: #4
I agree that LocalMktTime and LocalMktDate shouldn't be handled by LocalDate/Time since the time zone might not be known. But IMHO UTCDateOnly could be handled by a LocalDate with time zone UTC.

What do you think?

Originally posted by @chrjohn in quickfix-j/quickfixj#460 (comment)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.