quentinsf / ansible-webfaction Goto Github PK

Hi, I'm trying to determine if anyone is maintaining the webfaction module for Ansible.
Ansible created a bug in several modules by setting the default type of variables to string if no type is defined. ansible/ansible-modules-extras#1732

Should not be a huge fix to add type definitions, but I haven't seen any updates on this here
https://github.com/ansible/ansible-modules-extras

I'm getting errors that looks like this
╰─›ansible-playbook playbook.yml
[DEPRECATION WARNING]: Instead of sudo/sudo_user, use become/become_user and make sure become_method is 'sudo' (default).
This feature will be removed in a
future release. Deprecation warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.

PLAY [webfaction] **************************************************************

TASK [setup] *******************************************************************
ok: [wf-198-58-114-22.webfaction.com]

TASK [Create a test domain] ****************************************************
fatal: [wf-198-58-114-22.webfaction.com]: FAILED! => {"changed": false, "failed": true, "module_stderr": "Shared connection to wf-198-58-114-22.webfaction.com closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n File "/tmp/ansible_Vtqrc7/ansible_module_webfaction_domain.py", line 170, in \r\n main()\r\n File "/tmp/ansible_Vtqrc7/ansible_module_webfaction_domain.py", line 134, in main\r\n positional_args = [session_id, domain_name] + domain_subdomains\r\n**TypeError: can only concatenate list (not "str") to list\r\n**", "msg": "MODULE FAILURE"}
to retry, use: --limit @/Users/karasek/Dev/work/TS-Sites/template/playbook.retry

PLAY RECAP *********************************************************************
wf-198-58-114-22.webfaction.com : ok=1 changed=0 unreachable=0 failed=1

Hi,

I've got a few potential improvements but I don't have the time to shepherd them through the Ansible PR process.

Would it be feasible to submit them here. This module could become a testing ground for new features and the work of getting them merged into ansible could happen once they had been used by more people than just me. ;-) I think it would be easier to get feedback and discuss design here than it would be on Ansible core.

In webfaction_site you have these comments:

# If it exists with the right I{, we don't change anything.
# Should check other parameters.

I hit exactly this issue. As a quick fix I was going to implement a new 'state' value - maybe called 'recreate'...

        if site_state == 'recreate':
            webfaction.delete_website(session_id, site_name, site_ip)
        else:
            module.exit_json(
                changed = False,
            )

Is this worth a pull request?

great work, this is exactly what I have been looking for

this is great ! thank you very much

I found these modules while searching for a way to deploy into existing webfaction web apps

I have found this one, which on the surface seems to have some overlap
https://github.com/bitmazk/ansible-webfaction-gunicorn-django