feedback about ember-cli-dependency-checker HOT 7 CLOSED

@rwjblue should confirm, but it should also be possible for us to delete extra directories not actually used by the addon. If not, we should open an ember-cli issue so that it becomes possible.

Although the addon generator spews out lots of folders to make it easy for the general case, specialized plugins shouldn't include the same directory soup.

I have opened a tracking issue: ember-cli/ember-cli#2404

from ember-cli-dependency-checker.

@quaertym I will test this addon in some of my apps after work today :)

from ember-cli-dependency-checker.

@stefanpenner Please do, my team greatly benefitted from this.

I tag the item with the commit that fixes it above. Some them are not very clear though.

from ember-cli-dependency-checker.

@stefanpenner Please review completed items if you have time.

For the open items:

i feel this should be an ember-cli thing, and we should always include the stack

Does this contradict with what @rwjblue suggested here #4?

it might be strange that the EmberCLIDependencyChecker constructor has sideaffects beyond setting up the object

When the object is constructed, we want to immediately check dependencies. Is there a better way to do this? (edit: I think this is what we want.)

will https://github.com/quaertym/ember-cli-dependency-checker/blob/v0.0.5/index.js#L30-L31 be a problem if people bower link or npm link to different versions?

This is the output when you specified ember-cli v0.1.1 in your package.json and npm link ember-cli v0.1.2: (edit: It seems alright.)

version: 0.1.2-master-602a1c4558

Missing npm packages: 
Package: ember-cli
  * Specified: 0.1.1
  * Installed: 0.1.2

Run `npm install` to install missing dependencies.

from ember-cli-dependency-checker.

@rwjblue any comments on @stefanpenner 's feedback and the last open item?

from ember-cli-dependency-checker.

@stefanpenner any comments about the last open item?

from ember-cli-dependency-checker.

The last open item would be wonderful but doesn't block us. Some future refactoring can tackle it

from ember-cli-dependency-checker.