Idea: fail build if peerDep is missing? about ember-cli-dependency-checker HOT 7 OPEN

in theory that sounds like a good idea, though in general I'm a little worried about it due to the other issues that peer dependencies have.

one example is ESLint plugins and ember-cli-eslint: the plugins usually declare an eslint peer dependency, but since the Ember app only has a dependency on ember-cli-eslint (which depends on broccoli-lint-eslint which depends on eslint) yarn will show warnings during yarn install. I'm worried that we'll run into similar issues 🤔

from ember-cli-dependency-checker.

I see.

Would it be possible to inspect the "final graph" (if there is such a thing) to check for the presence of eslint?

from ember-cli-dependency-checker.

yes, but you might actually end up with several different versions if a subsubsubsubsubdependency misbehaves and has eslint as an actual dependency.

from ember-cli-dependency-checker.

We can only warn instead of failing build.

from ember-cli-dependency-checker.

@quaertym true, but yarn and npm already do that, so I'm not sure where the benefit would be

from ember-cli-dependency-checker.

One benefit is that npm and yarn only warn once upon install, whereas this addon would warn upon each invocation of ember...

from ember-cli-dependency-checker.

Also, see ember-cli/rfcs#112 for some background context here. I still need to dust off that RFC and re-submit it to emberjs/rfcs though...

from ember-cli-dependency-checker.