Git Product home page Git Product logo

Comments (7)

stefanpenner avatar stefanpenner commented on May 30, 2024

I'm not sure how one knows a command is valid if the dependencies may or may not be in-sync.

Ember install is currently used to add dependency not install missing ones. So it must validate existing ones are correct to proceed (today)

from ember-cli-dependency-checker.

runspired avatar runspired commented on May 30, 2024

ember install can also be used to update an installed addon to it's latest version, which should work even if the addon is declared but not installed at that moment.

from ember-cli-dependency-checker.

stefanpenner avatar stefanpenner commented on May 30, 2024

Unfortunately due to the chicken + egg nature of installing something with itself (the update case of ember install) It is something we must discourage.

As mentioned in the other issue, there are plans to create a more standalone installer capable of doing this. As we would like to migrate to a more constraint based installer (over the one npm client ships by default).

from ember-cli-dependency-checker.

rwjblue avatar rwjblue commented on May 30, 2024

I disagree with the premise of the issue. We need to validate the deps for any command to be ran and function. If we do not check deps and provide helpful information then those commands themselves may be completely non-functional.

from ember-cli-dependency-checker.

runspired avatar runspired commented on May 30, 2024

@rwjblue could we build a way to flag a command as "warn only" instead of error out?

from ember-cli-dependency-checker.

rwjblue avatar rwjblue commented on May 30, 2024

Maybe? There is already both an ENV var check (if present disables checking) and the automatic detection (and changing the default to warn instead of error) when a symlink is detected in node_modules (going on the assumption that you have npm link'ed).

As far as I know, we do not directly have access to the command name being invoked here (though we may be able to add that).

from ember-cli-dependency-checker.

jacobq avatar jacobq commented on May 30, 2024

I think the SKIP_DEPENDENCY_CHECKER=true opt-out method is reasonable. To me, it's a release valve for when a bug in ember-cli-dependency-checker is stopping a command that would otherwise be successful. (It also helps me avoid going nuts when I just want to run ember -v but some npm craziness has temporarily broken node_modules.)

Do people still want to keep this issue open? (It's 2+ years old now.)

from ember-cli-dependency-checker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.