Comments (7)
I'm not sure how one knows a command is valid if the dependencies may or may not be in-sync.
Ember install is currently used to add dependency not install missing ones. So it must validate existing ones are correct to proceed (today)
from ember-cli-dependency-checker.
ember install
can also be used to update an installed addon to it's latest version, which should work even if the addon is declared but not installed at that moment.
from ember-cli-dependency-checker.
Unfortunately due to the chicken + egg nature of installing something with itself (the update case of ember install
) It is something we must discourage.
As mentioned in the other issue, there are plans to create a more standalone installer capable of doing this. As we would like to migrate to a more constraint based installer (over the one npm client ships by default).
from ember-cli-dependency-checker.
I disagree with the premise of the issue. We need to validate the deps for any command to be ran and function. If we do not check deps and provide helpful information then those commands themselves may be completely non-functional.
from ember-cli-dependency-checker.
@rwjblue could we build a way to flag a command as "warn only" instead of error out?
from ember-cli-dependency-checker.
Maybe? There is already both an ENV var check (if present disables checking) and the automatic detection (and changing the default to warn instead of error) when a symlink is detected in node_modules (going on the assumption that you have npm link'ed).
As far as I know, we do not directly have access to the command name being invoked here (though we may be able to add that).
from ember-cli-dependency-checker.
I think the SKIP_DEPENDENCY_CHECKER=true
opt-out method is reasonable. To me, it's a release valve for when a bug in ember-cli-dependency-checker
is stopping a command that would otherwise be successful. (It also helps me avoid going nuts when I just want to run ember -v
but some npm
craziness has temporarily broken node_modules
.)
Do people still want to keep this issue open? (It's 2+ years old now.)
from ember-cli-dependency-checker.
Related Issues (20)
- Bower deprecations in ember-cli 4.3 HOT 5
- peer-dependency of ember-cli 3.2 HOT 2
- Fix ember-cli 4.x deprecations
- Reported Vulnerability for package set-value/2.0.1 with ember-cli-dependency-checker/3.3.1 version
- does not properly detect resolutions
- 3.3.2 includes the CI config
- Detect yarn and surface correct error message HOT 2
- Add ember-cli team to `npm` for releases... HOT 1
- Incorrectly flagging optional dependencies HOT 6
- dev dependencies required to be installed before running ember-deploy HOT 4
- Unhelpful message `TypeError: Invalid Version: *` HOT 2
- Broken with npm5 generated shrinkwraps HOT 2
- Yarn workspaces HOT 2
- Gets confused when dealing with Bower packages installed via Yarn HOT 5
- can't find packages if different directory specified in .bowerrc HOT 1
- False positive `Missing npm packages:` when installing from tarball HOT 1
- Yarn PnP Support HOT 1
- Idea: fail build if peerDep is missing? HOT 7
- Resolution of file: paths still failing HOT 3
- Major version release notes?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli-dependency-checker.