Comments (16)
@Fryie why do you install ember-cli globally on CI server?
from ember-cli-dependency-checker.
How would I be running ember version
on the CI server if ember-cli is not installed? I suggest removing the ember version
instruction from that specific section, it is highly confusing.
from ember-cli-dependency-checker.
OK, how about this?
(which ember && ember version) || (rm -rf node_modules/ bower_components/ && npm install && bower install)
I am not quite sure how ember
is cached between builds.
from ember-cli-dependency-checker.
Why is the ember check needed?
from ember-cli-dependency-checker.
I think what @mixonic had in mind was that not installing dependencies again if they are already satisfied. ember version
is the simplest command that triggers dependency check.
from ember-cli-dependency-checker.
Correct, the intent is to trigger the check of deps against shrinkwrap.json.
I doubt the SW checker is getting a lot of usage on npm 2.x though. Eager to try it out with 3.x
from ember-cli-dependency-checker.
Hm, so in case the dependencies didn't change at all and are still cached (semaphore does this by default for example) it would make the build somewhat faster...
You'd still have to run ember version
from node_modules/ember-cli/bin/
, though (since that's likely not in the path), so that part of the instruction will need to be changed.
I'd probably add some additional explanation along the lines of:
Some build servers cache the
node_modules
folder, so it is possible that your app's dependencies are already installed. In order to verify that the dependencies are not out of date you can usenode_modules/ember-cli/bin/ember version
, which (if Ember is installed) will check that the dependencies are correct.
And then maybe something about not needing to install a global ember-cli on the CI server and that tests can be run via npm run test
.
from ember-cli-dependency-checker.
@Fryie which ember
checks whether ember
is installed or not, see my comment above.
from ember-cli-dependency-checker.
but why should ember be in the path on a CI server?
from ember-cli-dependency-checker.
but why should ember be in the path on a CI server?
yes, this also confuses me. it should be self contained in node_modules, so running:
npm install
npm run test:ci
from ember-cli-dependency-checker.
@stefanpenner So the only way to be sure that all dependencies are satisfied is to remove node_modules
and reinstall with npm i
? Then there will be no benefit for caching node_modules for people using npm-shrinkwrap
.
from ember-cli-dependency-checker.
well, if the folder is cached and a version of ember is installed, then node_modules/ember-cli/bin/ember version
should check the contents of the node_modules
folder against the shrinkwrap - so that might actually work for caching.
from ember-cli-dependency-checker.
@Fryie Is this better?
([ -f node_modules/ember-cli/bin/ember ] && node_modules/ember-cli/bin/ember version) || (rm -rf node_modules/ bower_components/ && npm install && bower install)
from ember-cli-dependency-checker.
I think that works, at least on my CI server it does (I didn't add the [ -f node_modules/ember-cli/bin/ember ]
part, but it is somewhat cleaner having it).
from ember-cli-dependency-checker.
Skipping that part results in No such file or directory
error if node_modules
does not exist.
from ember-cli-dependency-checker.
For further discussion: #42
from ember-cli-dependency-checker.
Related Issues (20)
- Bower deprecations in ember-cli 4.3 HOT 5
- peer-dependency of ember-cli 3.2 HOT 2
- Fix ember-cli 4.x deprecations
- Reported Vulnerability for package set-value/2.0.1 with ember-cli-dependency-checker/3.3.1 version
- does not properly detect resolutions
- 3.3.2 includes the CI config
- Detect yarn and surface correct error message HOT 2
- Add ember-cli team to `npm` for releases... HOT 1
- Incorrectly flagging optional dependencies HOT 6
- dev dependencies required to be installed before running ember-deploy HOT 4
- Unhelpful message `TypeError: Invalid Version: *` HOT 2
- Broken with npm5 generated shrinkwraps HOT 2
- Yarn workspaces HOT 2
- Gets confused when dealing with Bower packages installed via Yarn HOT 5
- can't find packages if different directory specified in .bowerrc HOT 1
- False positive `Missing npm packages:` when installing from tarball HOT 1
- Yarn PnP Support HOT 1
- Idea: fail build if peerDep is missing? HOT 7
- Resolution of file: paths still failing HOT 3
- Major version release notes?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-cli-dependency-checker.