Git Product home page Git Product logo

Comments (8)

stefanpenner avatar stefanpenner commented on May 29, 2024

This also seems to be a problem if the destination repo has no bower.json file. Such as: https://github.com/furf/jquery-ui-touch-punch

I suspect if the folder exists, but no bower.json file exists we should likely just best-effort assume all is satisfied.

from ember-cli-dependency-checker.

quaertym avatar quaertym commented on May 29, 2024

I was not sure how to handle this. @stefanpenner I will try your suggestion.

from ember-cli-dependency-checker.

stefanpenner avatar stefanpenner commented on May 29, 2024

@quaertym Ya, I am not quite sure the best way either, maybe someone else has a better idea.

For reference my solution/workaround was to merely "vendor" this dependency and commit it to my project manually.

from ember-cli-dependency-checker.

quaertym avatar quaertym commented on May 29, 2024

@stefanpenner 👍 for vendor approach but I think many users are not aware of it. We should cover this use case anyway. There is also a problem with static files that bower manages see this pr #12.

from ember-cli-dependency-checker.

mixonic avatar mixonic commented on May 29, 2024

Yeah, this bit us as well today. Ugly and more than a bit perplexing.

from ember-cli-dependency-checker.

soulcutter avatar soulcutter commented on May 29, 2024

I ran into this with an http dependency

    "sinon": "http://sinonjs.org/releases/sinon-1.12.1.js"

Not sure if it's relevant, but I did notice that bower_components/sinon does have a .bower.json file in there - is that artifact usable in lieu of a bower.json file?

from ember-cli-dependency-checker.

shaunc avatar shaunc commented on May 29, 2024

I ran into the same "sinon" issue ... and also now have a problem with antiscroll as installed by ember-cli-ember-table. Could someone explain the "vendor" workaround? I have got things working temporarily by simply deleting the reference in bower.json after I install, but this is obviously just a temporary patch for development.

from ember-cli-dependency-checker.

rupurt avatar rupurt commented on May 29, 2024

@amk221 @stefanpenner thanks for the suggestion. Is there any tooling support for vendoring a dependency or do I just need to put it in the my_ember_app/vendor directory manually?

I've got it working manually but it would be nice if there was a command I could run to update the package.

from ember-cli-dependency-checker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.