qmk / qmk_userspace Goto Github PK

Information

• None of the other issue templates apply

Description

Thanks for this repo. 🙇 Finally there is a way to build keymaps without installing ton of stuff on my machine.

I noticed that ghcr.io/qmk/qmk_cli image already has latest pip https://github.com/qmk/qmk_cli/blob/d3917b10e7621632098028a68982727b10ec83f5/Dockerfile#L8, so why is there a need to download get-pip.py?
And if there is a need for latest pip why not do python3 -m pip install --upgrade pip like qmk_cli does?

Also downloading .py file with blobs looks suspicious. It even has a comment in the start of the file:

But that's exactly what i would say if i was up for something nefarious :D

Description

Hello, can we have a shell.nix file here like in the firmware repo?
Thanks before.

Describe the Bug

When running the GitHub Actions build flow, it succeeds even if it fails to compile and/or produce any artifacts.
I'm not sure whether that was intended.

Additional Context?

Example run: https://github.com/andrebrait/qmk_userspace/actions/runs/7771624531