qlik-oss / leonardo-ui Goto Github PK

CCI 1.0 are being sunset in 60 days, we need to update this build pipeline.

Description

Documentation bug
lui-button--error in documentation should be lui-button--danger

Steps to Reproduce

1. attempt to use lui-button--error styling in a button
2. see that it doesn't color red per docs.

Expected behavior

the button would be styled red

Actual behavior

the button is styled default

Versions

• Leonardo UI: 1.0.2
• Browser: Chrome
• Operating system: Win10
• [Other relevant versions]

Description

The placement of tool tips and popovers are not correct if the user has scrolled.

Steps to Reproduce

1. Using Chrome or Firefox load: https://qlik-oss.github.io/leonardo-ui/tooltip.html
2. Scroll downwards on the page.
3. Hover over tooltip area to have it render.

Expected behavior

Tool tip docked to the element that renders it.

Actual behavior

Tool tip is rendered above the expected area.

Versions

• Leonardo UI: 1.3.0
• Browser: Chrome 62, Firefox 57
• Operating system: Mac 10.12.6

Will Leonardo ever be offered via bower? We use bower for our front end modules and npm for backend.

A BlackDuck Protex scan failed on this repository.

Number of files needing identification: 2

If you are unsure how this process works, please contact trunk team on Slack.

No more automated issues will be created on this repository until this issue
is closed.

Please prioritize and solve this as soon as possible. If the files
has been identified already, you may ignore and close this issue.

Description

In the contributing.md doc in the developing section, it states to run npm run docs to compile the documentation. This command returns an error.

https://github.com/qlik-oss/leonardo-ui/blob/master/CONTRIBUTING.md#developing

Steps to Reproduce

1. enter npm run docs
2. watch the error

Expected behavior

docs get compiled

Actual behavior

error occurs:

Versions

• Leonardo UI: 1.0.2
• Browser: Chrome
• Operating system: Windows 10
• [Other relevant versions]

Resolution

I added "docs": "node ./tools/build-docs.js" to the scripts section of the package.json and then ran npm run docs. All good!

Description

The .lui-icon--minus class is defined twice in the css and the last occurrence is wrong and should therefore be removed.

Steps to Reproduce

1. Add an element with the class lui-icon--minus
2. Inspect it and see that it has two declarations in the css with different values

Expected behavior

The first declaration should be kept and the second which is wrong should be removed

Versions

• Leonardo UI: 1.1.0
• Browser: All
• Operating system: All

Select component cannot be used with multiple. This seems to be a missing feature.

<select class="lui-select lui-select--large" multiple >

Description

lui-icons are not rendering

Steps to Reproduce

1. Created an angular app
2. in a template added a button with a span tag that contains a class pointing to a cogwheel.
3. render in browser.

Expected behavior

cogwheel renders

Actual behavior

I get a capital V

Versions

• Leonardo UI: 1.01
• Browser: Chrome
• Operating system: Windows 2016
• [Other relevant versions]

Code Sample

css

@font-face {
    font-family: "lui-icons";
    src: url("node_modules/leonardo-ui/dist/lui-icons.woff") format('woff');
}

html

<button style="float:right;margin-right:40px;margin-top:20px;" class="lui-button  lui-button--toolbar-inverse" id="config-dialog" ng-click="model.openConfig()"><span class="lui-button__icon  lui-icon  lui-icon--cogwheel" aria-hidden="true"></span></button>

Screenshot of result