Git Product home page Git Product logo

arfind's People

Contributors

aarexer avatar mikhailchuryakov avatar timuranosov avatar

Stargazers

 avatar

Watchers

 avatar  avatar

arfind's Issues

Test naming refactoring

Need to rename our tests as it stipulated in conventions.
The test name should represent what the test doing.
Now I see a lot of strange names like: oneNotFullWordTest.

Colored sources

Add color matching capability to source.
And show colorized source list - it will improve the perception

Refactoring alert window

When we do our first run of application we should show alert window.
This window should be a big Button with message.
After we clicked on it - we should open Configure window and set configuration.

Logic repeat

In our companies cache we have Map of companies' names and SearchDetails.
But company name is already one of the fields in SearchDetails.
That is why there are some problems in logic which we need to fix.

Table cell division

We want to make our table with data we found look excel-like.
That is why we need to add extra cells for user-friendliness.

Price column handling

In some excel files price column has custom type - with prefix with currency.
For example:
144 руб.

And when we get value from such columns - we get only 144.

We need to understand - how we will detecting price in each excel - cause all of them have different structure.

Add NUMERIC case

If we have only numeric in cell (without text) app cannot read it, consequently find matches, becouse we have only case STRING.
Add case NUMERIC and tests for it

Modify the results html table

Now if i am working with multiple files and not all matched strings have one length - result of searching is ugly.
Need to improve the html table generator - all matched lines should fill the whole space.

Save search history

Maybe we should need to add search history - pop-up list when we type our search request?

Selected checkboxes

When we want to perform a new search, checkboxes selected before become unselected.
But for user-friendliness we need to make them selected even after the new search.

Lock windows

When we open 'Configuration' (or 'Help' etc) window, we still have access to 'MainApplication' window. So we can open a few such windows, but that is not logical.
Need to block 'Main' window than we work with another.

Add "Select all" button

When we save configuration, close app, and enter it, we have not selected source. So if we have a lot of this it will be problem to select all.
We need to add button for this.

Windows resolution problem

We don't know average sizes of windows and need to fix it because we can't see windows on low-resolution displays

Excel type check

Now we rely on file extension when we try to understand type of Excel, we have smth like:
`
if (name.endsWith("xls")) {
return ExcelExtension.XLS;

    } else if (name.endsWith("xlsx")) {
        return ExcelExtension.XLSX;
    }`

Of course - it's bad and we should check it in a different way.

First init of application

If we havn't any config.csv file - we havn't got any sources for search
Now - we show Button for this purpose before main window.
But it's ugly to see

I think we should show main window and in sources area pick button and warning for set sources.

Create logger

Need to add logging for debug application properly

  • Add logback and slf4j to parent pom.xml
  • Add logging for critical places of project.

Create test table and see results

Create test table with tow columns - one column is String - names - ObservableList, and other - ListView.
Need to see how it looks - is it good solution or not?

New UI in edit company dialog

I think it should be only button in search line. After we clicked on it - we see FileChooser, and after we choose file - textEdit with absolute path and button for change it - like now.

To sum up: first - only button, after clicked - button with text edit

File existence

With the help of config file we load companies and excel file paths to configuration window.
However, something bad may happen and these excel files may be deleted.
That is why we need to check if these files exist and only after this load them to our configuration window.

set priority map

Map with two priorities - 0 and 1.
0 for full coincidence
1 for not full

Cache companies

I think we should have cache for companies and use file only as a persistent store.
For example and basic usage we can use: Guava - Caching

With cache we can implement Company DAO.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.