Git Product home page Git Product logo

qb-pawnshop's Introduction

qb-pawnshop

Pawn Shop For QB-Core

License

QBCore Framework
Copyright (C) 2021 Joshua Eger

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program.  If not, see <https://www.gnu.org/licenses/>

qb-pawnshop's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

qb-pawnshop's Issues

[SUGGESTION] Adding more locations?

I just updated and decided to try adding a new location in the south side of the city but when I go there I am not getting a menu. Am I missing something? This is how I edited the config.lua below.

Config.PawnLocation = {
[1] = {
coords = vector3(412.34, 314.81, 103.13),
length = 1.5,
width = 1.8,
heading = 207.0,
debugPoly = false,
minZ = 100.97,
maxZ = 105.42,
distance = 3.0
},
[2] = {
coords = vector3(183.33, -1320.07, 29.32),
length = 1.5,
width = 1.8,
heading = 59.42,
debugPoly = false,
minZ = 100.97,
maxZ = 105.42,
distance = 3.0
},
}

[BUG] Melted items lost if inventory is too full

Describe the bug
Melted items are lost when trying to pick them up from the pawnshop without enough space in your inventory.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Pawn Shop
  2. Melt some items
  3. Wait until items are melted
  4. Fill inventory (ensure not enough space for melted items)
  5. Pickup Melted Items from Pawn Shop
  6. It will say "You received X items"
  7. Then it says "Inventory too full"
  8. items are not in your inventory and there is no longer an option to pick them up

Expected behavior
a) Check player has enough inventory space before trying to add the items.
b) Maintain the option to pick up melted items if the first attempt was unsuccessful

Screenshots
If applicable, add screenshots to help explain your problem.
image

Questions (please complete the following information):

  • Occurs with current version
  • Are you using custom resource? No
  • Have you renamed qb- to something custom? No

Additional context
N/A

bug

when player set -1 they get what they have in inventory they selling it then -1 they get it back az much they want
sory for my english

[BUG] Melting items

We found a bug exploit about melting large amount of items. So we tried melting 20x rolex, waited 3 minutes for it to be done. On the script, it's supposed to give us 1 diamond, 1 goldbar, and 1 electronickit per 1 rolex. Here's what we found. Our inventory is almost full, almost has no more space left. We picked up the rewards, one press it gave me 20 diamonds then says my inventory is full. Second press it gave me 20 more and says my inventory is full. Third press it gave me another 20 diamonds. After selling it at the pawnshop, I went back to the melting tab and I could still pick the same rewards. 60 more diamonds to sell, and another, and another. The only time it'd be gone is when I went inside my apartment.

[BUG] Not functioning

Script loads fine, upon going to the blip, there is no interaction with the door, nor is there an interior portion of the building, tried adjusting the vectors, no dice.

FR: Minimum quantity required for smelting

Issue
In the old version of qb-pawnshop, you could set a necessary amount of items to smelt, which in return gave you gold bars. Now, when you smelt, you are given a minimum of 1 item at a 1:1 ratio.

Expected:
16x (16 = variable) Watches smelts into 1x (1 = variable) gold bar

What happens now
16x watches will smelt into 16x gold bars, 16x diamonds, 16x electronic kits

Proposed
I think adding a minRequired to each smeltable item would be beneficial to this script or else it's hard to update this on an existing server with gold bars already set by the economy to a rare value. It would significantly lower the price of goldbars with the 1:1 ratio on exchange.

Notes
If I am able to create a solution, I will PR it, but until then sharing my suggestion as it's going to be on the backburner for as this will now be the last script I work on upgrading.

pawnshop menu

when i sell something the menu closes i have to go back 5 6 steps then come back again then go back and come to open the menu again to sell something cant you make it when you sell something to open automaticly after every sell like the vehicleshop

[BUG] max items?

Is there a max limit to how many items you can have in there?

It was working find with like 20 items, I have added items now upto 60 items Including weapons and now getting errors when trying to open the pawnshop menu, as well as nothing showing

[Suggestion] QoL Improvement

Make it so when you sell an item it re-opens the selling menu instead of completely closing so you don't have to leave the zone and re-enter

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.