Comments (2)
gedge
commented on June 15, 2024
You don't need to have your key added to submit a PR.
Further, I think it's much more common to have several PRs approved by the upstream author before they even consider adding someone's key (and that presumes that they want to add others to their repo). Trust often has to be earned.
Having said all that: glad to see another contributer to the project - hope you can get your PRs approved.
from gremgo.
qasaur
commented on June 15, 2024
Agree with @gedge. Keys aren't required for contributions, and it is usually better to submit pull requests so other people have the chance to voice their opinion if they have any concerns.
from gremgo.
Related Issues (20)
- broken code in request.go HOT 1
- Hook for connection failures HOT 1
- Client hangs on backend error
- How does this compare to go-gremlin/gremlin? HOT 2
- How to use session?
- Error due API change on "github.com/satori/go.uuid"
- Documentation clean-up HOT 1
- Bad uuid.NewV4 call HOT 1
- [SCRIPT EVALUATION ERROR] on setting UUID HOT 1
- Request: return struct instead of interface{} HOT 2
- go get github.com/qasaur/gremgo returns an error HOT 3
- Where is NewSecureDialer? HOT 2
- Hang on server failure
- isConnected is not an public HOT 1
- websocket message length too small
- Unable to do a bulk request on database, number of documents returned is too low?
- Replace satori/go.uuid HOT 1
- Purpose of rebindings in Execute method HOT 1
- readme example is not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gremgo.