Git Product home page Git Product logo

Comments (22)

vnbang2003 avatar vnbang2003 commented on June 13, 2024

@harisibrahimkv ignore it. I was about to say help with about us page

from wye.

vnbang2003 avatar vnbang2003 commented on June 13, 2024

@staranjeet Can you help us create the functionality ?

from wye.

taranjeet avatar taranjeet commented on June 13, 2024

yeah. What should be the fields here? Name, Email, Address, Mobile, Inquiry msg, and captcha.
Also This involves creating a new model, so that model should be in profiles app or any other app?

from wye.

vnbang2003 avatar vnbang2003 commented on June 13, 2024

Yes captcha is good point.
I was think no need to store this ? but if email goes in spam it better to store ?
@theskumar @kirang89 @kracekumar what do you guys think ?

from wye.

taranjeet avatar taranjeet commented on June 13, 2024

yeah suggestions please. I was a little busy yesterday so I missed the hangout. When are we having the next hangout?

from wye.

kirang89 avatar kirang89 commented on June 13, 2024

@vnbang2003 Quick comments:

  • Why do we need to ask for phone number ? The lesser information we ask for, the better, IMO.
  • I'm not sure that I understand the purpose of the page. I thought it was just an interface for either an individual or an organisation to reach out to us with comments/feedback. Did I miss something ?

Apart from this, I agree with Vijay about not having to store any information. The page is just a simple interface for reaching out to us.

from wye.

vnbang2003 avatar vnbang2003 commented on June 13, 2024

The purpose of the page is to get feedback . It a simple interface with more details to understand what feedback they want to give to us.
Mobile number can be optional this might help us create account for them if they face trouble creating account .

from wye.

kirang89 avatar kirang89 commented on June 13, 2024

Dropdown with option (Profile, Workshop, Organisation and others)

The reason I asked about the purpose of the page was because of the above option.

Mobile number can be optional this might help us create account for them if they face trouble creating account .

Agreed. So, now if someone has trouble creating an account, the dropdown should be optional as well right ?

from wye.

vnbang2003 avatar vnbang2003 commented on June 13, 2024

agreed

from wye.

vnbang2003 avatar vnbang2003 commented on June 13, 2024

@staranjeet Can it be possible to get this feature asap so we can get it live along with beta version live ?

from wye.

taranjeet avatar taranjeet commented on June 13, 2024

when is beta going to be live?

from wye.

vnbang2003 avatar vnbang2003 commented on June 13, 2024

Probably Wednesday or Thursday . We are just wait for E2E machine provision.

from wye.

deshraj avatar deshraj commented on June 13, 2024

Great. :)

from wye.

taranjeet avatar taranjeet commented on June 13, 2024

I have pushed a branch contact-us-page and created a diff from my master.

Some things needs discussion or suggestions:

  • Placed the views code in profiles app. Is it ok or not?
  • The mail template is not beautified. The details are listed on individual lines.
  • Taking name, email, content, query_topic and mobile(optional). Labels needs to be changed.
  • The thank you message and url (after a response is saved)
  • What captcha should I use? I was thinking of recaptcha and for that we need to register here

@vnbang2003

from wye.

vnbang2003 avatar vnbang2003 commented on June 13, 2024

Placed the views code in profiles app. Is it ok or not?

  • For now it ok.

The mail template is not beautified. The details are listed on individual lines.

  • Have provided feedback to extend now. @harisibrahimkv Can help you generate it
  • We need two email (1) to Python express team(regional leads and admins (2) to requester

Taking name, email, content, query_topic and mobile(optional). Labels needs to be changed.

  • Can we even verify email id and mobile number verificaiton in form validation ?

The thank you message and url (after a response is saved)
What captcha should I use? I was thinking of recaptcha and for that we need to register here

@kracekumar Can you help register for recaptcha ?
@staranjeet Let us know what you need once registered ?

from wye.

taranjeet avatar taranjeet commented on June 13, 2024

Have updated the pull as per the changes suggested by @vnbang2003 .

What does verifying email and mobile means here? Do you means sending mail and message to the one who is trying to contact us, so that we can verify is he/she authentic?

I think for a contact us page, this should not be required. Captcha is enough to prevent us from bots. We need to discuss regarding this.
@kracekumar @vnbang2003 @kirang89

from wye.

vnbang2003 avatar vnbang2003 commented on June 13, 2024

I mean validate email and mobile else we will be listed soon in spams.
For not let move on without captcha. Let open issue and plan for v0.2

from wye.

taranjeet avatar taranjeet commented on June 13, 2024

so u mean a individual clean function for mobile and email which checks the following

  • clean_mobile : whether the entered mobile number is of 10 digits or 11 for landline
  • clean_email : checks whether the email is a valid email through regex.
    ?

from wye.

vnbang2003 avatar vnbang2003 commented on June 13, 2024

yep

from wye.

taranjeet avatar taranjeet commented on June 13, 2024

ok i will do this. rest all changes are fine. If so then I will create a PR from wye's master now?

from wye.

vnbang2003 avatar vnbang2003 commented on June 13, 2024

@staranjeet Have shared feedback on your branch.

from wye.

taranjeet avatar taranjeet commented on June 13, 2024

yeah I have seen. I will do the changes.

from wye.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.