Try and create a search query builder for the Search service. At this time, there is only a string based query parameter. It would be nice to research the possibility to create a filter using a fluent api, instead of just a string.

StatusService.DeleteStatus now deletes specific moments. According to the api, if the time parameter is omitted, all statuses on a given day are deleted.

To implement this, we need a new api call: StatusService.DeleteAllStatusesOnDate. This would also take a single DateTime but just omit the time from the request.

Currently the AddBatchStatus sends all status objects with the net flag set to false. Also, the cumulative type is always set to none.

We need to be able to control those parameters when sending data. The Net flag does completely modify the formatting of the data part of the request.

Implement API call [Add Batch Status]
https://pvoutput.org/help.html#api-addbatchstatus

Apparently using the raw GitHub readme file isn't completely compatible with the NuGet readme renderer.
https://www.nuget.org/packages/PVOutput.Net/

At first glance it's these GH tags giving problems:

<details> <summary>

Perhaps create a smaller version of the readme, specifically for the NuGet page.

It would be nice to optionally log the requested Uri and Response content to a separate logging system. Ideally with another dependency.

Perhaps Debug or Trace? Has to work with Release mode binaries though.

The current GitHub action seems abandoned:
brandedoutcast/publish-nuget#58

The action now gives an error each time whilst actually completing to publish the NuGet package including it's symbols:

Your package was pushed.
error: Value cannot be null. (Parameter 'path2')

setup-dotnet now seems a much better option, see this comment for info:
brandedoutcast/publish-nuget#21 (comment)

Create an extension method for adding the PVOutputClient as a singleton to the service collection. This would make it a lot easier to integrate PVOutput in for example ASP.NET Core applications.

See:
https://aws.amazon.com/blogs/developer/working-with-dependency-injection-in-net-standard-inject-your-aws-clients-part-1/

Something like:

public void AddPVOutputClient(this IServiceCollection, Action<PVOutputOptions> optionsSetter)
{
   optionsSetter.Invoke();
   Services.AddSingleton<PVOutputClient>(new PVOutputClient(options.GetApiKey()))
}

Implement API call [Delete Status]
https://pvoutput.org/help.html#api-deletestatus

Types:

• IInsolationService
• IOutputService
• IStatusService

All use parameters with the the name date which triggers the following code analysis warning:

warning CA1716: In virtual/interface member XXX, rename parameter date so that it no longer conflicts with the reserved language keyword 'Date'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member.

The parameters have to be renamed to something that won't cause conflict.

For example GetDayStatisticsForPeriodAsync; both datetimes should have the same datepart to it.

I found recently that pvoutput has deprecated the addbatchoutput API, batching is now part of addoutput, but batching is only available for donations mode, see jwillemsen/saj_collector#34. It looks this project needs to be updated because it uses addbatchoutput.jsp as far as I can tell.

Implement the Register Notification Service
https://pvoutput.org/help.html#api-registernotification

As most of the library is now covered by interfaces to help users with unit testing, it makes sense to decrease the visibility of the underlying actual implementations. It doesn't make sense to have the interfaces public as well as the implementations. The latter can go back to internal. This is especially true for all the modules.

It's also worth looking at the rest of the public facing types regarding this point.

I am very interested in people using this library and how it is working for them. I can see the NuGet downloads slightly increasing, but I don't know who's using it. No public repository is currently dependant on it.

Do you use this library?
If so, be it negative or positive please share your thoughts! 🙂 I'd like to hear them, one way or the other.

The PVOutput UI for maintaining system information, only provides the following options when entering shade information:

• None
• Low
• Medium
• High

It would be better to return this information in an enum format, instead of the current string type. Note that it's also possible to enter a time frame for the shade to occur. This information is currently not being returned by the PVOutput api.

Larger systems usually have multiple inverters so it would be nice if there was an option to combine these outputs and thus preventing having to use multiple systems in PVOutput. As not all values can be added up the highest of those should be reported to PVOutput.

Verify if any string value is accepted or if it's a fixed list.

Hi @pyrocumulus, nice library, I'm using it in an upcoming Windows Service that syncs GoodWe API to PVOutput. Somewhere in that code, I have a class that wraps your PVOutputClient for configuration and DI purposes, and it has a property:

public PVOutputClient ApiClient { get; }

Now I want to test that my code calls your code, without actually calling your code, it being test data and all which I don't want to be sent to PVOutput.

Could you consider interfacing the PVOutputClient and its services, so it can be mocked for unit tests?

Add Xml doc for all public facing types, methods and parameters. Also package the resulting documentation in the output assembly, so it can be packed into the Nuget package.

Pushing only a date and generation seems to work well. However when paired with, peaktime/conditions/consumption the api seems to return 200 however no output is record at PVOutput's end.

Sample with which I experienced this

            var builder = new OutputPostBuilder();
            var output = builder.SetDate(DateTime.Today.AddDays(-2))
                .SetGenerated(10000)
                .SetPeakTime(new DateTime(2019, 12, 8, 10, 15, 23))
                .SetCondition("Fine")
                .SetTemperatures(5.2m, 9.4m)
                .SetConsumption(2000)
                .Build();

            var response = await client.Output.AddOutputAsync(output);

On various places a time-only data aspect is expressed as a DateTime, resulting in weird tricks to combine dates and times in new DateTime.

This can be avoided if the time-only aspects are expressed as TimeSpan.

The API docs still use the following format:

https://pvoutput.org/help.html#api-addoutput

While the new format is:

https://pvoutput.org/help/api_specification.html#add-output-service

Changes needed:
Go through the whole code base and update all links in the old format */help.html#* to new url's. Has to be done manually because the anchors are also renamed, not only moved.

We need to resolve these issues for better compatibility with different languages/runtimes:

Warning CA1716 In virtual/interface member XXXXXXXXXXX, rename parameter date so that it no longer conflicts with the reserved language keyword 'Date'. Using a reserved keyword as the name of a parameter on a virtual/interface member makes it harder for consumers in other languages to override/implement the member.

Violations in:
PVOutput.Net D:\Git\pvoutput.net\src\PVOutput.Net\Modules\Interfaces\IStatusService.cs
PVOutput.Net D:\Git\pvoutput.net\src\PVOutput.Net\Modules\Interfaces\IOutputService.cs
PVOutput.Net D:\Git\pvoutput.net\src\PVOutput.Net\Modules\Interfaces\IOutputService.cs
PVOutput.Net D:\Git\pvoutput.net\src\PVOutput.Net\Modules\Interfaces\IInsolationService.cs
PVOutput.Net D:\Git\pvoutput.net\src\PVOutput.Net\Modules\Interfaces\IInsolationService.cs
PVOutput.Net D:\Git\pvoutput.net\src\PVOutput.Net\Modules\Interfaces\IInsolationService.cs

Describe the bug

Some parameters are getting processed by UrlEncode write. This results in %2520 instead of %20 for a space character.

To reproduce

Steps to reproduce the behavior:

1. Setup client
2. AddStatusRequest
3. Use the TextMessage property and use a space character in the text

Expected behavior

It should not double encode.

Additional context

More than one parameter ought to be affected by this. Manual UrlEncode should only be applied in the curious case of the + character.

At the moment it's just reading to end; it would be cleaner to have it read with while/peek, just like the other readers.

Describe the bug

The orientation "EW" isn't known (https://github.com/pyrocumulus/pvoutput.net/blob/develop/src/PVOutput.Net/Enums/Orientation.cs).

To reproduce

1. Set up client
2. Configure PVOutput panel orientation "EW"
3. Call method System.GetOwnSystemAsync()
4. See error

Stack Trace

System.ArgumentException: Invalid description 'EW' for enum Orientation (Parameter 'enumerationDescription')
   at PVOutput.Net.Objects.Core.FormatHelper.DescriptionToEnumValue[TEnumType](String enumerationDescription)
   at PVOutput.Net.Objects.Modules.Readers.SystemObjectStringReader.<>c.<ParseBaseProperties>b__2_9(ISystem t, String s)
   at PVOutput.Net.Objects.Core.BaseObjectStringReader`1.ParsePropertyArray(TReturnType target, TextReader reader, Action`2[] properties)
   at PVOutput.Net.Objects.Modules.Readers.SystemObjectStringReader.ParseBaseProperties(ISystem target, TextReader reader)
   at PVOutput.Net.Objects.Core.BaseObjectStringReader`1.ParseProperties(TReturnType target, TextReader reader, CancellationToken cancellationToken)
   at PVOutput.Net.Objects.Core.BaseObjectStringReader`1.ReadObjectAsync(TextReader reader, CancellationToken cancellationToken)
   at PVOutput.Net.Objects.Core.BaseObjectStringReader`1.ReadObjectAsync(Stream stream, CancellationToken cancellationToken)
   at PVOutput.Net.Requests.Handler.RequestHandler.ExecuteSingleItemRequestAsync[TResponseContentType](IRequest request, Dictionary`2 loggingScope, CancellationToken cancellationToken)

Undocumented though: https://pvoutput.org/help/api_specification.html#id66

Rewrite all unit tests to use the new constraint model instead of the old Assert class system.

https://github.com/nunit/docs/wiki/Assertions

Restructure namespace and folder hierarchy to lessen namespace requirements. No more structure per type/class, only by functionality

Instead of providing two separate doubles, create a type for this purpose.

Implement the Post System call
https://pvoutput.org/help.html#api-postsystem

Implement API call [Get Supply]
https://pvoutput.org/help.html#api-getsupply

https://pvoutput.org/help.html#api-getstatus

Day statistics

This applies to the following interfaces:

• IFavourite.Orientation
• ISystem.Orientation
• ISystemSearchResult.Orientation

But because we are now returning string values in these properties, this is a breaking change.

Implement API call [Add Batch Output]
https://pvoutput.org/help.html#api-addbatchoutput

Microsoft.CodeAnalysis.FxCopAnalyzers is deprecated, we need to migrate analysers to Microsoft.CodeAnalysis.NetAnalyzers.

System.GetOwnSystemAsync() throws:

'Invalid description 'null' for enum Orientation

SecondaryOrientation is the string "null", because I don't have a secondary array for that system.

https://den.dev/blog/docs-github-actions/

Implement the Deregister Notification Service
https://pvoutput.org/help.html#api-deregisternotification