Git Product home page Git Product logo

aws_sso_containers's People

Contributors

blakemotl-rl avatar cjallen88 avatar leodag avatar pyro2927 avatar slinkymanbyday avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

aws_sso_containers's Issues

Doesnt support non alphanumeric chars to differenciate accounts

My company has a bunch of aws accounts with SSO names like this...

  • mycompany (dev)
  • mycompany (logs)
  • mycompany (prod)

Im guessing the extension is truncating the end off the name (maybe because of non alphanumerics?) and all accounts end up opening in the same container. Obviously this isnt what's intended :)

Control over the container colors and icons

As a big user of containers, I would like to limit the extension to creating containers for AWS with a specific icon only (and any color).

Not necessarily, but perhaps also limit to creating contains with a specific color (and any icon).

Or both, a specific icon and color combo for all containers.

I know this has the potential to "confuse" open tabs, but I accept that.

JUST BROKEN: Method to extract name and role of AWS account to choose correct container is broken just now!

AWS must have just changed the format/content of how they handle SSO connections as your plugin (which I rely on EVERY DAY) now gets confused as to which AWS account is being connected to. The name of the container chosen is now, the literal string "name" instead of the actual name of the AWS account. Therefore, no matter which account I click on, I get the same container named "name" as my container. This, of course, means I cannot open more than 1 AWS account at a time which breaks the point of this plugin. Please fix right away. I can donate money if needed.

Open new tab next to the tab where the click happened.

This is more esthetics any anything else, but I like for my tabs to be grouped together. Root tab (click)->new tab spawn. This extension opens a new tab at the end of all already opened tabs and I would love if that was configurable.

Keeps asking which container to open a new tab in

Hi. This is probably a PEBKAC issue (i.e. user mistake, for those unfamiliar with the term), but I can't find a way to fix this.

Whenever I pick a link to open the AWS console with one of the accounts, I started getting a page like this:
Screenshot_2024-06-09_at_8_08_42 AM

I think this started when I once mistakenly clicked the checkbox.

Before that, clicking on an account link from the list of AWS accounts just opened the portal in that account directly.

I tried clicking on the checkbox again but it doesn't make a difference.

I think that what I need is to somehow clear an internal flag controlled by this checkbox.

How can I get back to the old behaviour which just opened the new account page directly?

This is with extension release 1.9 updated today.

Support SSO Portals In Container Tabs

Currently only the extension only works on SSO Portals that are NOT in a container tab already. This is very limiting as it's pretty normal to be logged into many SSO Portals at the same time using different container tabs. For example when switching between clients.

Steps to reproduce

Result

  • The AWS Console is opened in a tab in the same container as the SSO portal

Expected Result

  • The AWS Console is opened in a tab in a container named after the account/permission set

Destination URL parameter seems to be ignored after new tab is opened

Hello!
We were exploring using this feature of the AWS SSO console to generate links that take people straight to a codebuild run. It seems to work fine in chrome or in a private firefox window with the extension disabled but not when using the extension. The url format looks something like this: https://myaws.awsapps.com/start/#/console?account_id=012345678910&role_name=ReadOnly&destination=https://us-west-2.console.aws.amazon.com/codesuite/codebuild/012345678910/projects/deployment/build/deployment:aa0015aa-aaa3-4a8a-aaaa-5b1d4a1b9df3?region=us-west-2
The login happens and the tab is opened but it takes me to the console homepage not the codebuild output as its supposed to. Seems like the destination parameter is dropped somewhere along the way.

Not working after updating to v1.1

This plugin seems to have stopped working for me today following the update to v1.1.

When logging into an AWS account, the initial new tab with the "loading" page comes up, which would usually be closed and replaced with a logged-in session to the AWS Console in a tab container.

Instead, this now sits and loads for a while, before returning an error:
image

Disabling the AWS SSO Containers plugin resolves this, but obviously starts the Console session in a normal tab.

I've tried changing the naming convention in your new settings page, and deleting the existing AWS tab container, but the error persists.

Support signin.aws.amazon.com/saml

Hi!

Currently, I make use of the page https://signin.aws.amazon.com/saml to select the account and role I am going to access. I'm afraid that the extension is not working for this. Whenever I click sign in, it just enters without a container.
This is how the interface looks:
aws

Would be lovely if you could also make this work, let me know if I can provide anything further. Happy to do a PR

[ENHANCEMENT] Avoid different AWS accounts using the same container colour when opening side to side

I understand the colour of a container is decided once the first time is created.
It would be nice to have it dynamically changed to avoid having multiple Aws accounts open side to side that incidentally have the same container colour.
I currently mitigate this keeping an empty tab between the accounts.

E.g. in this screenshot the three green tabs are three separate AWS accounts. I can of course change the container colour, but this won't prevent it to have the same colour of another account will open in the future side-by-side.

image

Container name is shortened after latest update

Hi, after the last update when I am in a container, I see the container name in the URL field is now much shorter. Before I don't remember if it showed the whole container name, but now I count only 14 characters. Many of my accounts have the same beginning so now I can't immediately see which account it is, it would be nice if this was configurable.
thanks!

Secondary account linked to AWS SSO portal not launching in separate container

Everything works as expected with all accounts and roles controlled by my organization listed under "AWS Account" on my AWS SSO portal page. However, there is another account we do not own or control but have access to in order to manage the environment. It appears as separately in the portal. When I launch this account, it does not launch in its own container.

Plugin version: 1.3
Firefox version: 116.0.2 (64-bit) - MacOS

Workaround for an issue with long container names

Hi @pyro2927, thank you so much for this extension, I've been using it for a while now and it makes dealing with frequently switching roles way easier. This isn't a problem with the AWS SSO Containers addon really, but the Firefox Multi-Account Containers addon has a long-standing issue where long container names wrap in a way that makes them jumbled and sometimes illegible:

container-name-wrapping-fixed

As far as I can tell, the Mozilla team has ignored the issue Long Names Word wrap are overlapping with other entries
#2544
, which is probably fair enough given the usual 25-character limit. That doesn't apply to this addon, so a while back I patched in a few minor changes to add an option to limit the max length and truncate the name with an ellipsis:

container-name-dialog-fixed

That turned out to work really well, except if you make the length so short the names end up being identical. Anyway, I put the changes on a fork of the repository https://github.com/acahill/AWS_SSO_Containers, which is now trailing a little bit but still works just fine for me. Is that useful to anyone else? I could rebase it and make a pull request if it helps.

Latest version not launching into new account

when clicking on an IAM role to assume, it opens a new tab with signing in, then nothing, it doesn't launch the new container.

Error message:

Something went wrong.
We could not sign you in to XXXX (YYYY).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.