Git Product home page Git Product logo

Comments (6)

owickstrom avatar owickstrom commented on May 28, 2024

Hmm, not able to recreate this. Could you provide a minimal project and list the commands you're running? Which versions of purescript-spec, psc and pulp are you using?

Thanks!

from purescript-spec.

 avatar commented on May 28, 2024

Sure, here's output from my shell; let me know if you need any more info:

==> mkdir example

==> cd example

==> pulp -v
4.3.0

==> psc --version
0.7.0.0

==> pulp init
[installations elided]

==> pulp build --to out.js
* Building project in /Users/am/w/example2
* Build successful.
* Bundling Javascript...
* Bundled.

==> node out.js
Hello sailor!

==> rm -f out.js

==> pulp dep i purescript-spec
[installations elided]

==> pulp build --to out.js
* Building project in /Users/am/w/example2
* Build successful.
* Bundling Javascript...
The module could not be parsed.

* ERROR: Subcommand terminated with error code 1

==> psc-bundle output/**/*.js --module Main --main Main > out.js
The module could not be parsed.

==> rm -rf output/Test.Spec*

==> psc-bundle output/**/*.js --module Main --main Main > out.js

==> node out.js
Hello sailor!

from purescript-spec.

owickstrom avatar owickstrom commented on May 28, 2024

Thank you!

It seems that the escape sequence at https://github.com/owickstrom/purescript-spec/blob/12ee764274c0900c4f8167dd2ecb2b5f815a9280/src/Test/Spec/Console.purs#L22 gets interpreted during the PS -> JS compilation. The module in output/ contains the unescaped character which causes the bundle to fail. I'll try to move the string literal with the escape to a foreign function and see if that works.

Related issues: purescript/purescript#1265 and purescript/purescript#1266

from purescript-spec.

owickstrom avatar owickstrom commented on May 28, 2024

I did a workaround for this and released a new version 0.7.1. Please let me know if it works out.

Thanks for your feedback!

from purescript-spec.

 avatar commented on May 28, 2024

The new version works - thank you!

from purescript-spec.

michaelficarra avatar michaelficarra commented on May 28, 2024

FYI purescript/purescript#1265 is fixed now!

from purescript-spec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.