beforeAll hook and Spec Identity monad about purescript-spec HOT 10 OPEN

@fsoikin ping

from purescript-spec.

I don't quite understand what the problem is. Can't you just create your own alias type Spec = SpecT Aff Unit Effect Unit?

from purescript-spec.

The problem is: why this is not by default in the library.

The problem is not with the alias, I described it, if one uses beforeAll hook one cannot run it simply with:

launchAff_ $ runSpec [ consoleReporter ] spec

but need:

launchAff_ =<< void <$> runSpecT defaultConfig [ consoleReporter ] spec

Do you use beforeAll hook in tests?

from purescript-spec.

Ah, I think I see: you're complaining that beforeAll requires the base monad to be MonadEffect, right?

If so, I cannot answer your question: I did not write this library, so I don't know the original motivation.

from purescript-spec.

so I don't know the original motivation.

Maybe it was overlooked. This change doesn't seem to break anything.

I thought you were the last active maintainer -) Who should we ping? @safareli

from purescript-spec.

Haven't done any PureScript for past couple years...

from purescript-spec.

Haven't done any PureScript for past couple years...

So far we need a brave one. @fsoikin ?

from purescript-spec.

Ok, so after considering this for a bit, I think I don't want to replace Identity with Effect, because this would impact existing tests that might count on the purity of the base monad.

In practice using beforeAll requires only very few changes to the code - the type of specs and the entry point, - so really the missing part is a comment on beforeAll explaining the issue and describing the solution.

And if you really want to have the Effect-based tests supported by the core library - how about creating a parallel type alias (e.g. SpecEff or something) and entry point function (runSpecEff)?

from purescript-spec.

SpecEff looks too ad-hoc. How about naming it SpecE and runSpecE for the sake of brevity?

from purescript-spec.

SpecE reads like it has to do with errors.

from purescript-spec.