Git Product home page Git Product logo

Comments (8)

andreiborisov avatar andreiborisov commented on August 30, 2024 1

@edouard-lopez I've already fixed it in my PR: #68

from pure.

edouard-lopez avatar edouard-lopez commented on August 30, 2024

Hi @schrodincat,
you're right, I reckon the docker image I used for the tests give false positive.

I'm working on it, thanks :)

from pure.

edouard-lopez avatar edouard-lopez commented on August 30, 2024

Nice catch!
The tests should've catch this, I'm working on it.

from pure.

edouard-lopez avatar edouard-lopez commented on August 30, 2024

@schrodincat It should work now, can you review it? I also added tests on the installer, see how to run them locally.

You might need to update your PR #68

from pure.

andreiborisov avatar andreiborisov commented on August 30, 2024

I can check it, but not before Tuesday, unfortunately😔

Sent with GitHawk

from pure.

edouard-lopez avatar edouard-lopez commented on August 30, 2024

Does this issue still stand?

from pure.

andreiborisov avatar andreiborisov commented on August 30, 2024

Does this issue still stand?

Yes

from pure.

edouard-lopez avatar edouard-lopez commented on August 30, 2024

The current test for the manual install is invalid.

from pure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.