Comments (9)
Scratch that, the problem was that I was running β― make test-pure-on FISH_VERSION=3.3.1 CMD="fishtape tests/_pure_prompt_virtualenv.test.fish"
- which actually runs all the tests instead of restricting them.
from pure.
Hello @dwt,
Sure, PRs are welcome β€οΈ
Suggestion
A variable defining the symbol for each indicator could do the trick, e.g declaring
_pure_set_default pure_symbol_virtualenv "π"
_pure_set_default pure_symbol_kubernetes "βΈοΈ"
By default, I would prefer having it empty for now, to have opt-in mechanism.
Could you try to update the test as well? They are still buggy when you run them all, but you should be able to run the one related to one feature, like:
β― make dev-pure-on FISH_VERSION=3.1.2 CMD="fishtape tests/_pure_prompt_virtualenv.test.fish"
from pure.
Hm, that doesn't seem so easy, I'm getting hangs in the test suite with errors like this:
fish: Unknown command: _print_filename
/tmp/.pure/tests/migration-to-4.0.0.test.fish (line 1):
_print_filename $current_filename
^
in command substitution
called on line 2 of file /tmp/.pure/tests/migration-to-4.0.0.test.fish
/tmp/.pure/tests/migration-to-4.0.0.test.fish (line 2): Unknown command
@mesg (_print_filename $current_filename)
^
After that the test container just hangs indefinitely, until I manually kill the container. Any advice?
from pure.
I will add variable, so people can disable those features if need be:
_pure_set_default pure_enable_virtualenv true
_pure_set_default pure_enable_kubernetes true
from pure.
@edouard-lopez were you able to make any progress on this? I too am looking for this (similar) functionality but honestly don't see k8s context support in the current code base. Was that a plugin you added or something else?
from pure.
Hello @zonywhoop, no progress on my side @dwt was working on a PR, I believe.
However, I see two features in this issue:
- add a flag to control virtualenv display and add a customizable prefix (cf. functions/_pure_prompt_container.fish)
- add support for k8s context + customizable prefix. There are several prompts that offer k8s support, we can get inspired by them:
I'm going to create another issue for the kubernetes one.
from pure.
see Add kubernetes/k8s support #322
from pure.
@dwt @zonywhoop
K8s support has been shipped with https://github.com/pure-fish/pure/tree/v4.6.0
from pure.
I'm working on the Python/virtualenv feature on #325
from pure.
Related Issues (20)
- type: Unknown option '--quiet' HOT 1
- prompt character broken HOT 3
- Change git branch color HOT 3
- [request] Is there anyway to have the following prompt: $tail on $git_branch HOT 1
- Missing blank line between prompts? HOT 2
- Add CI for MacOS
- MacOS: warning: An error occurred while redirecting file '/proc/1/cgroup' HOT 26
- Prompt outputting _pure_is_inside_container 1 HOT 4
- head: cannot open '/proc/1/sched' for reading: No such file or directory HOT 6
- Prompt displays '2' character around user@host section HOT 1
- VI-mode visual mode prompt HOT 2
- Cannot uninstall 4.4.1 HOT 2
- WSL 1 shows user@hostname HOT 3
- Add kubernetes/k8s support HOT 1
- Is there any option in pure like truncation_length in starship? I want it to show last three parent folder. HOT 2
- π Revamp README and docs
- Pure prompt contains newline in VSCode terminal HOT 3
- Improve `git` prompt during rebase conflicts HOT 6
- Add escape codes for shell integration (OSC 133)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pure.