v2.0.0 about pure HOT 13 CLOSED

@rafaelrinaldi okay, thanks. I will try to make it possible.

from pure.

@rafaelrinaldi I'm not comfortable with tests as an after-thought. However, as there is plenty of "legacy" code I don't want to block the release, instead add tests little by little and release more frequently.

from pure.

@schrodincat cool
Yes we try to follow semver as much as possible, but I introduced some breaking changes on the recent version as I rename some variables in conf.d/pure.fish (74f028d, 731a406, 9f8b8a9).

While revamping the README.md I realized we have some inconsistencies in the naming of variables. This would be nice to improve that before releasing 2.0.0.

from pure.

Hello,

Thank you all for an awesome plugin.

I have just upgraded to the latest version with Vim mode support. Is there any way to not showing the Vim mode indicator on the screen?

Thanks,
Canh

from pure.

Hey @nautilus28, this is happening because you probably have Vim mode enabled by default. To disable it you can either remove fish_vi_key_bindings from your Fish configuration file or run fish_default_key_bindings.

from pure.

@rafaelrinaldi Many thanks for getting back. What I want is to enable Vim mode by default, but not showing mode indicator on the terminal, is it possible?

from pure.

This is not possible right now. We will show the indicators for vim mode at all times as of #58. I'm happy to accept a PR to get this in though.

from pure.

@rafaelrinaldi we should add some tests on fish_prompt and pre_prompt (which are a big and ugly functions 😢)

from pure.

@edouard-lopez I agree. We could do this after the v2 release though?

Many thanks for the hard work and getting the peding issues resolved. I feel like we're pretty much ready for a revamped version release, what do you think?

from pure.

@rafaelrinaldi @schrodincat

I think we should postpone async support to a future version and release a 2.0.0 as we do have a bunch of new features that have been shipped, the code evolved a lot, is stable and tested.
Plus we could announce 3.0.0 support :)

What do you think?

from pure.

Seems reasonable to me.

We are not using semantic versioning though?

Also while we are on it, I think we need to make dev branch and commit only release code on the master, since installation scripts are always using latest master commit. Right now user potentially can install some commit in between versions. It’s just safer to have dev branch. I’d even say we can adopt git flow, but that’s not necessary by any means.

from pure.

I wrote a proposal convention for renaming variable in #130 if you want to chime in.

from pure.

The roadmap looks good to me 👍 Having Git async support behind a feature flag definitely makes sense.

from pure.