Comments (13)
@rafaelrinaldi okay, thanks. I will try to make it possible.
from pure.
@rafaelrinaldi I'm not comfortable with tests as an after-thought. However, as there is plenty of "legacy" code I don't want to block the release, instead add tests little by little and release more frequently.
from pure.
@schrodincat cool
Yes we try to follow semver as much as possible, but I introduced some breaking changes on the recent version as I rename some variables in conf.d/pure.fish (74f028d, 731a406, 9f8b8a9).
While revamping the README.md I realized we have some inconsistencies in the naming of variables. This would be nice to improve that before releasing 2.0.0
.
from pure.
Hello,
Thank you all for an awesome plugin.
I have just upgraded to the latest version with Vim mode support. Is there any way to not showing the Vim mode indicator on the screen?
Thanks,
Canh
from pure.
Hey @nautilus28, this is happening because you probably have Vim mode enabled by default. To disable it you can either remove fish_vi_key_bindings
from your Fish configuration file or run fish_default_key_bindings
.
from pure.
@rafaelrinaldi Many thanks for getting back. What I want is to enable Vim mode by default, but not showing mode indicator on the terminal, is it possible?
from pure.
This is not possible right now. We will show the indicators for vim mode at all times as of #58. I'm happy to accept a PR to get this in though.
from pure.
@rafaelrinaldi we should add some tests on fish_prompt
and pre_prompt
(which are a big and ugly functions π’)
from pure.
@edouard-lopez I agree. We could do this after the v2 release though?
Many thanks for the hard work and getting the peding issues resolved. I feel like we're pretty much ready for a revamped version release, what do you think?
from pure.
I think we should postpone async
support to a future version and release a 2.0.0
as we do have a bunch of new features that have been shipped, the code evolved a lot, is stable and tested.
Plus we could announce 3.0.0
support :)
What do you think?
from pure.
Seems reasonable to me.
We are not using semantic versioning though?
Also while we are on it, I think we need to make dev
branch and commit only release code on the master
, since installation scripts are always using latest master
commit. Right now user potentially can install some commit in between versions. Itβs just safer to have dev
branch. Iβd even say we can adopt git flow
, but thatβs not necessary by any means.
from pure.
I wrote a proposal convention for renaming variable in #130 if you want to chime in.
from pure.
The roadmap looks good to me π Having Git async support behind a feature flag definitely makes sense.
from pure.
Related Issues (20)
- type: Unknown option '--quiet' HOT 1
- prompt character broken HOT 3
- Change git branch color HOT 3
- Add π to the virtualenv title so I know that's what I see HOT 9
- [request] Is there anyway to have the following prompt: $tail on $git_branch HOT 1
- Missing blank line between prompts? HOT 2
- Add CI for MacOS
- MacOS: warning: An error occurred while redirecting file '/proc/1/cgroup' HOT 26
- Prompt outputting _pure_is_inside_container 1 HOT 4
- head: cannot open '/proc/1/sched' for reading: No such file or directory HOT 6
- Prompt displays '2' character around user@host section HOT 1
- VI-mode visual mode prompt HOT 2
- Cannot uninstall 4.4.1 HOT 2
- WSL 1 shows user@hostname HOT 3
- Add kubernetes/k8s support HOT 1
- Is there any option in pure like truncation_length in starship? I want it to show last three parent folder. HOT 2
- π Revamp README and docs
- Pure prompt contains newline in VSCode terminal HOT 3
- Improve `git` prompt during rebase conflicts HOT 6
- Add escape codes for shell integration (OSC 133)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pure.