Git Product home page Git Product logo

Comments (4)

andreiborisov avatar andreiborisov commented on August 30, 2024 1

@rafaelrinaldi I’ll do a PR, no problems👌 I’ve managed to fix this issue, but I’ve also noticed there is something fishy going on (couldn’t help myself, sorry, I’m new to fish 😅).
Is there any reason we evoking pre_prompt through event handler? Because, it seems, it isn’t called when going through directory history. It is also not called on the terminal opening (at least for me with Terminal.app on macOS) which I believe is not intended behavior.

Sent with GitHawk

from pure.

rafaelrinaldi avatar rafaelrinaldi commented on August 30, 2024

@schrodincat Thanks for your suggestion. I had no idea this was possible. We will look into supporting this feature on pure.

In the meantime feel free to submit a PR if you feel like it.

from pure.

edouard-lopez avatar edouard-lopez commented on August 30, 2024

Could you create a dedicated PR for this? Having a smaller scope help review faster and release more frequently 👍

from pure.

andreiborisov avatar andreiborisov commented on August 30, 2024

@edouard-lopez no, I don’t think so, the underlying issue is the same as for #68, so if you fix one, you fix other automatically...

Sent with GitHawk

from pure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.