Git Product home page Git Product logo

Comments (6)

rafaelrinaldi avatar rafaelrinaldi commented on August 30, 2024

@edouard-lopez Doesn't this impact v1.0.0?

from pure.

edouard-lopez avatar edouard-lopez commented on August 30, 2024

@rafaelrinaldi which method of install did you used? sorry for the delay been busy.

I'm just discover the docker-fish image and it might be useful for developing/testing:

docker pull colstrom/fish
docker run -it colstrom/fish

Then in the docker:

apk-install  curl git
curl -Ls https://raw.github.com/rafaelrinaldi/pure/master/installer.fish > /tmp/pure_installer.fish
source /tmp/pure_installer.fish; and install_pure

Above command work fine:


Installing Pure theme
        Set environment variable: $FISH_CONFIG_DIR
        Set environment variable: $PURE_INSTALL_DIR
        Checking for git availability ✔
        Fetching theme's source ✔
        Backuping existing theme
 ✔
        Enabling autoloading for pure's functions on shell init ✔
        Enabling theme ✔
        Cleaning after install ✔

from pure.

rafaelrinaldi avatar rafaelrinaldi commented on August 30, 2024

@edouard-lopez Nothing to be sorry about 😉

Yeah, I just tried the vanilla installer script. Not sure why I got that error...

I will try testing within the Docker container when I have a chance.

from pure.

rafaelrinaldi avatar rafaelrinaldi commented on August 30, 2024

@edouard-lopez Just did another clean install run and it worked 👍

shrug

from pure.

rafaelrinaldi avatar rafaelrinaldi commented on August 30, 2024

@edouard-lopez Nevermind, it happened again. Just didn't happened during install. It seems like it can't find functions because they're installed under functions/theme-pure and it will look for .fish files under /functions. Is there a way to "source" them? I couldn't find any.

Maybe @BRJ have an idea on how to solve this?

from pure.

 avatar commented on August 30, 2024

@rafaelrinaldi I tried in a fresh install, without fisherman, and was able to repro the problem.

One issue could be in pure::enable_autoloading

if not test (grep "$THEME_PURE" $FISH_CONFIG_DIR/config.fish 2>&1 >/dev/null)
        echo "$marker" >> $FISH_CONFIG_DIR/config.fish
        echo "set fish_function_path $PURE_INSTALL_DIR" '$fish_function_path' >> $FISH_CONFIG_DIR/config.fish
end

I don't use a config.fish, so that code above will not write anything to any config, which means, when I start a new session, $PURE_INSTALL_DIR will not be set anywhere and fish will not be able to autoload the helper functions you put inside ~/.config/fish/theme-pure.

from pure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.