Use Case

ZFS supports per-volume encryption, but it lacks the option that sets "encryption on" and any option to specify the keysource.

Describe the Solution You Would Like

Add two options, encryption and key source

Describe Alternatives You've Considered

Create the volume outside of puppet

Use Case

If you want to create encrypted datasets/volumes automatically, the key material may only be generated during the initial setup.
This requires a fact that makes it possible to test for the presence of datasets/volumes in a pool so that the key material is not generated again.

Describe the Solution You Would Like

An simple puppet like this:
$facts['zfs']['']['<volume/dataset name>']
Optional the fact can provide additional information about the pool and the volumes/datasets
So that this code will work:

if $facts['zfs']['foo']['bar'] {
exec { 'create_key_material':
....
}
zfs { 'bar':
...
require => Exec[...]
}
}

Describe Alternatives You've Considered

Do this manual on the server, because the key material will only present temporary on an ram disk on the server.
So the "creates" of exec will not an option.

Describe the Bug

Hi,
Because of the way ZFS properties can be passed and are returned by the zfs get commands, Puppet applies properties even though they already have the correct values, e.g.

quota changed '4.88T' to '5000G' (corrective)`
reservation changed '6T' to '6597069766656' (corrective)

Expected Behavior

When the values match, the module should detect it and not attempt to set them again.

Steps to Reproduce

1. Set a quota of 5000G
2. Set a reservation of 6597069766656

Environment

• Version 8.4.0
• Platform Debian 12

Additional Context

I thought of the following patch:

diff --git a/lib/puppet/provider/zfs/zfs.rb b/lib/puppet/provider/zfs/zfs.rb
index 976d9bf..b97ec0c 100644
--- a/lib/puppet/provider/zfs/zfs.rb
+++ b/lib/puppet/provider/zfs/zfs.rb
@@ -82,7 +82,7 @@ Puppet::Type.type(:zfs).provide(:zfs) do
    :secondarycache, :setuid, :sharenfs, :sharesmb,
    :snapdir, :sync, :version, :volsize, :vscan, :xattr].each do |field|
     define_method(field) do
-      zfs(:get, '-H', '-o', 'value', field, @resource[:name]).strip
+      zfs(:get, '-p', '-H', '-o', 'value', field, @resource[:name]).strip
     end
 
     define_method(field.to_s + '=') do |should|

It would prevent issues when the Puppet configuration uses exact values:
But it doesn't help when we pass Puppet human-readable values, e.g.

quota changed '5368709120000' to '5000G' (corrective)

Maybe the solution would be to:

• apply the above patch
• convert human-readable values to exact values before applying them