Git Product home page Git Product logo

Comments (5)

ncoghlan avatar ncoghlan commented on August 15, 2024

#26 adds a new render_errors parameter to accept_token, as well as corresponding test cases for the render_errors=None case.

from flask-oidc.

puiterwijk avatar puiterwijk commented on August 15, 2024

So, the problem with this way is that we are currently sending JSON objects as they are defined in the OAuth2 specification, to improve compatibility.
If we were to allow anything, it would require users of this function to figure out how they are supposed to encode it themselves.

from flask-oidc.

ncoghlan avatar ncoghlan commented on August 15, 2024

I'm fine with using a boolean toggle instead (for lazy-encoding-or-not). The key problem with the status quo is that it's incompatible with frameworks like Flask-RESTful that expect a dict object that the framework then encodes.

from flask-oidc.

ncoghlan avatar ncoghlan commented on August 15, 2024

#27 is an alternative PR that just lets users turn off the eager error rendering for compatibility with REST frameworks that automatically encode all responses as JSON.

from flask-oidc.

puiterwijk avatar puiterwijk commented on August 15, 2024

#27 has now been merged.

from flask-oidc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.