Comments (19)
How long can you stay in this deprecated functionality? Instead of going backward, this library should be updated to use proper library as described here:
https://itsdangerous.palletsprojects.com/en/2.1.x/changes/
https://docs.authlib.org/en/latest/jose/jws.html
from flask-oidc.
@puiterwijk could this PR please be merged and released?
from flask-oidc.
@khteh you can install the changes introduced by #144 by specifying directly the MR or the commit you want in your pip install
command.
e.g.: pip install git+https://github.com/puiterwijk/flask-oidc.git@b10e6bf881a3fe0c3972e4093648f2b77f32a97c
On our end, we are using a custom security manager for Airflow to connect using OIDC, which relies on flask-oidc
underneath (https://flask-appbuilder.readthedocs.io/en/latest/security.html#authentication-openid). Because the dependency on itsdangerous
is not pinned, the latest build broke the oidc workflow to connect to Airflow, but adding the latest commit of #144 as dependency in our docker build (command above) fixed it.
Note that pip install git+https://github.com/puiterwijk/flask-oidc.git@refs/pull/144/head
as specified in #152 would also work if you don't want to freeze to a specific commit and benefit from the update made to the MR.
from flask-oidc.
So it's 2023, 4 months later, is this still the issue and is it not yet updated?
from flask-oidc.
Came here hoping for a fix too.
from flask-oidc.
Hello,
This class has been removed in itsdangerous
2.1.0 : https://itsdangerous.palletsprojects.com/en/2.1.x/changes/#version-2-1-0
It was mentioned in #3 ...
In your Pipfile, could you please add itsdangerous = "<2.1"
?
from flask-oidc.
@khteh well, one would need to have the proper rights on the repo for that, so this decision relies on @puiterwijk’s approval of the PR.
In the meantime targeting the code of the PR for the install is a workaround.
from flask-oidc.
if it fixed, why dont you get updated?
from flask-oidc.
Sorry, I mixed the Gitlab’s way of defining things. MR = Merge request (which is Gitlab’s denomination for Pull Request).
from flask-oidc.
For those using pipenv
: pipenv install git+https://github.com/puiterwijk/flask-oidc.git@refs/pull/144/head#egg=flask-oidc
from flask-oidc.
Yes. See #147 (comment)
from flask-oidc.
I honestly don't know, I had the same issue several days ago and thought it would be helpful to share ;)
from flask-oidc.
Apparently fixed in #144
from flask-oidc.
confirming that installing #144 fixes it.
from flask-oidc.
Fixed? Install? What do you mean and how? #144 is not even merged yet!?
from flask-oidc.
What stops you from merging and releasing the fix as a new version?
from flask-oidc.
Ok. Thanks. BTW, what's MR
?
from flask-oidc.
Are there any possible workaround this issue? It seems it will take a while to merge the fix to master.
from flask-oidc.
Still waiting on a fix…
from flask-oidc.
Related Issues (20)
- ERROR:flask_oidc:Expecting value: line 1 column 1 (char 0)
- flask oidc not redirecting to the application url HOT 1
- Unable to install flask-oidc version 1.4.0 on WSL HOT 1
- authorized registration isn't possible with oidc-register
- Deprecated oauth2client HOT 3
- itsdangerous 2.1.0 removed JSONWebSignatureSerializer HOT 1
- Add resource parameter to sent authorization URI HOT 1
- Clarification of discover_OP_information
- custom
- Is this repo dead? Anything we could help? HOT 1
- Unable to provide access token to client registration endpoint
- Unable to pip install from pull request HOT 2
- Errors during token validation because ADFS does not support introspection URL
- Flask oidc supports keycloak multi Relams
- Audience check ignored if no audience available in access token
- Bypass of "require_login()" leads to application crash(obviously)
- 2.0.0 now requires userinfo_uri HOT 1
- PLEASE depreciate the puiterwijk/flask-oidc repo HOT 3
- Is the logout route hardcoded? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flask-oidc.