ptsochantaris / trailer Goto Github PK

I would like a PR to be moved to participated section when i get a mention in the description or in a comment

Maybe there is somethin I didn't understand but here is my issue. I've registered many repositories in the app (>10). I get the new PR notifications in a good way but I don't have anything in the drop down menu:

Am I missing something or is it an actual bug?

Hi @ptsochantaris,

I was in the tube and I noticed that when I'm out of connection and I click in one of the PR's there is a red message that appears saying there is no connection.
My suggestion would be to have a button to refresh the content instead :)

Hi,

Is it possible to check if our branch is still mergeable?
Once in a while our branch gets unmergeable and there is no way of knowing it unless you go to the PR page and check the button.

Thank you

Right now "All Pull Requests" can get quite big (currently I see 45 PRs).
I would suggest to add some basic grouping or filtering.

If we go with the grouping path we can group the PRs by repository.

If we go with the filtering path I guess that this is going to be much more complicated and need some more discussion. My first though is to have a window where I can setup/edit the filters. The model of a filter needs to be discussed.
Once a filter is setup I can decide which filters should be displayed on the main dropdown (i.e. All PRs, filter1, filter2)
I think the way Pivotal Tracker "save search" works could be useful to gather some ideas. The main rationale behind this requirement for me is that I would like to see all the PRs of my team or a specific team.

Of course these two are not mutually exclusive, but I guess we need to prioritize them.

Hi,

I'm currently dealing with ~71 repos so it would be swell if you can display the repo name somewhere so I can quickly filter out the key ones. :)

I created a PR with no description, and Trailer then crashed.

Stacktrace:

http://cl.ly/image/0X2u1L2h1W1b

some people are not able to upgrade to 10.9 for various reasons, but i think 10.8 and 10.9 are on the majority of macs nowadays.

... in the "My pull requests" section.

Rationale: if I miss the notification, I might miss that I still have stuff to deploy.

Very minor: I had 1.0.1, when I checked for updates it asked me to update to version 1.0.1 but in reality it was updating to 1.0.3.

It would be nice to know when the app is reloading the data without having to click on the menu bar logo.

Ala Dropbox or CloudApp, maybe replacing the number or animating the logo of the app in the menu bar could to the trick ?

Would be nice to have if we could have a slightly different notification when we get mentioned in any PR comment.

Thoughts?

It seems a bit wasteful in terms of screen real-estate to show sections which don't contain any elements, plus having one empty section on top of another isn't the most aesthetically pleasing either.

Can we have the name of the person who issues the PR please?

Thank you

I never receive pull requests for repos I've forked and most of my repos are forks, so it was difficult to find the ones I might actually get PRs.

If this is typical how about an icon or hiding by default the forked repos?

It would be nice if there was a quick way to filter for specific text in the PR list (for instance, one notices a word or phrase in a notification and wants to quickly look it up) in the same way we can filter the Repo list in preferences.

When I click on a notification, the PR page show open in my browser.

@ptsochantaris
I think it would be nice to still see my latest 5 PR's that got closed, as that can mean I closed a PR or it got merged (which closes it as well)

It would be handy to have a menu item to mark all "red" pull requests as read.

For the second time that I updated trailer I got:

Is this a known bug ? Whenever this happens I have to reload all my projects.

It seems with the new change to clean up all merged PRs (without the dialog) closes the menu ( and also no longer opens it again ). I'd assume it would just remove them in place !

Currently the list can grow quite big, and it's a bit tiresome clicking in all "remove" buttons and they also have a bit of lag (a few ms to actually remove that PR)

Steps to reproduce:

1. Open the help window of another app, e.g. Safari
2. Place it under the area where the Trailer menu would open
3. Open the Trailer menu
4. The trailer menu will be obscured by the help window even though it opened after it

Will fix ASAP

I really miss a button that would make it clear that my settings and selected projects are going to be saved. Closing settings windows without some sort of 'apply' button always makes me scan through the layout 3 more times because I think I missed it :)

I heard you said we have a new version but I can't update :(

Version: 0.92

"a minute ago", "a few days ago", etc.
I appreciate it would grow the size of the menu, but it's helpful information to prioritise action on PRs.

Very easy to reproduce: Open preferences and resize the window. Will fix.

Are we interested in adding also CI information to the list?
It would be nice to see in the list the PR that are green and hence maybe ready to be merged.

It would be cool to see what repo a pull request belongs to, and also to be able to filter by repo.

I think in a UI perpective is not very nice seeing gravatars flashing while the menu is open. Thoughts ?

Ideally a users own comments/actions will be considered read.

This stays like this forever

I tend to use github by only responding to requests when I am actively mentioned.

The 'Participated' flag is incredibly useful, but what would be even more useful is if there were also a way to hide "All Pull Requests". In a large organisation this is just noise.

What would be even better would be a way to enable this setting only for certain repos. e.g. with my personal repos I am interested in every PR, with my organisation's repos I'm generally only interested in PRs in which I am mentioned.

Great product :)

The oldest PRs are the ones that need the attention (or need to get scrapped).
Show them on top by default, possibly with an option to reverse that?

I think it doesn't make sense that if I merge a PR it stands on my merged PR list. Thoughts ?

I'd love to be able to access Trailer using a global shortcut, use tab/arrow/vim-style navigation to step through pull requests, then select a PR using space/enter.

The list can easily become very long, and filtering would help a lot. The 'select all' and 'clear all' would ideally only work on the items in the filtered list.

Sorry to be a serial issue opener :D

I had one unread pull request (generated by a commit, not a comment), clicked on it and its own badge went away; but the number on the menu bar is still red.

I get that arrow misplaced from time to time. Nothing critical, but just to let you know :)

I get the counter red on my own pull requests when I push a commit to the relevant branch. Is that by design? I'd rather not get those notifications.

Sort them by name so it would be easier to find.
As they all start with the team name, your eyes can quickly scan certain character patterns.

I don't find the current sorting (by date) meaningful.

Sometimes it's relevant to know who is the author of certain notification. Either the author is now replying or a team member is commenting something etc..

Feasible?

Maybe add as option?

Thoughts ?

Not sure if it's easy or at all possible, but marking PRs that have unread messages (much like Github's notifications) would be quite helpful.

Perhaps having them on top of lists as well.

Crash log here.

Plus the obvious checkbox that mirrors the setting in the preferences dialog (which is getting crowded ^_^)

'nuff said hopefully.

Title says it all.

For some reason comments in commits (vs. comments on the PR itself) aren't showing up.

Right now I have a fixed red x on my trailer icon.
Tried to restart the app several times and to refresh it with no luck.
What could be the issue? What data I could provide to debug it?

http://cl.ly/image/1l3a2v1r1y1F