psalmody / dynamic-scrollspy Goto Github PK

Given the following markup, the current tree generation gets the links in the wrong order:

<h2>1</h2>
<h3>2</h3>
<h4>3</h4>
<h2>4</h2>
<h4>5</h4>

Yields:

1
  2
    3
    5
4

I've submitted pull request #8 which solves the issue for me and may also solve issue #7

For example:

<code>&lt;select&gt;</code>

Renders an actualy <select> HTML element in the scrollspy outline.

Would be best to have some error handling when header tags don't have id attributes and genIDs: false

When you have a fixed navbar, clicking the links results in the link target being obscured by the navbar. I was able to work around it like this:

$('.nav li a').click(function(event) {
    event.preventDefault();
    $($(this).attr('href'))[0].scrollIntoView();
    scrollBy(0, -100);
});

However, it would be nice if you provided a targetOffset option.

When a heading is a child of an element, it does not get rendered in the resulting list. Not sure if this was intentional.

For example, this h2 will not get rendered.

<h1>rendered</h1>
<h2>rendered</h2>
<h3>rendered</h3>
<div>
<h2>not rendered</h2>
</div>