Git Product home page Git Product logo

kubejs-botania's Introduction

KubeJS-Botania

KubeJS support for botania

kubejs-botania's People

Contributors

prunoideae avatar

Stargazers

 avatar

Watchers

 avatar  avatar

kubejs-botania's Issues

Added Own removal in 1.20.1 {enhancment}

As of 1.20.1 Botania have blocked event.remove({ output: "botania:Item" }) and event.remove({ output: 'botania:Item', type: 'botania:pure_daisy' })

this may not be on purpose but do to this modpack creators can't remove recipes to use this to add new ones, why i'm asking even if its not perfect to add somthing so recipe for the pure daisy can be messed with again

(other then that the mod seem to work perfect)

[1.19.2] Crash at startup with latest Botania update

The latest update to Botania causes Kubejs Botania to create a crash at startup.

(Crash Report)[https://gist.github.com/DelviousCrafts/2c2a2d8dc67fbc776130d9b0eaace860]

Versions:

  • Minecraft: 1.19.2
  • Forge: 43.2.11
  • KubeJS: 6.0-build.142
  • Botania: 440
  • Kubejs Botania: 1.1
  • Architectury: 6.5.85
  • Curios API: 5.1.4.1
  • Patchouli: 77
  • Rhino: 2.2-build.268

[1.19.2] Issues with serialisation of mana infusion recipes, and probably petal + terra plate recipes.

While working on some additional mana infusion recipes, I noticed that none of them were working (warning in KJS log is [03:51:14] [WARN ] Error creating recipe botania:kjs_6e7zdw5jceao5e7lvfy5bsgu1[botania:mana_infusion]: {"type":"botania:mana_infusion"}: java.lang.NoSuchMethodError: 'com.google.gson.JsonObject net.minecraft.world.item.ItemStack.kjs$toJson()'). Interestingly those were only logged as warnings, not errors, but that's irrelevant to the issue itself other than making it take slightly longer for me to spot. :)

Since other recipe types were working fine, I took a look at the code and seem to have found the cause & a solution, but haven't had a chance to make the changes myself to verify it.

Basically,

appears to be broken, and I suspect will work if changed to match the way it's handled here:

which is also the way KubeJS itself handles it now (for the past few months anyway) for built-in recipe types (such as shapeless crafting).

I'm guessing that PetalRecipeJS and TerraPlateRecipeJS will need to be changed too, although I haven't tested recipes using those methods yet.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.