Comments (7)
Thanks for the clarification π
from prometheus.
It seems like with the upgrade of golangcilint
some of the linter don't work (or work?) as expected. You can see an example of it here: #14215
@aknuds1 should we rollback #14153 until we figure it out?
from prometheus.
Why does a performance linter matter for test files?
from prometheus.
Why does a performance linter matter for test files?
It doesn't - but it's not the way it worked in the previous version thus can be considered a breaking change?
from prometheus.
When perfsprint
was originally introduced it linted all of the test files too: #14091 - with the upgrade of golangcilint
it stopped.
So at the very minimum, it is now inconsistent.
from prometheus.
I noticed that this particular line should have been caught by the linter and failed: https://github.com/prometheus/prometheus/blob/main/rules/manager_test.go#L198
It's not a regression. That line is not caught because of a perfsprint exclusion in .golangci.yml. That exclusion had to be updated for v1.59.0. That's why you see more things getting caught when downgrading.
from prometheus.
π€¦ so this is actually text-based exclusion in golangcilint
TIL.
This comment from BjΓΆrn makes all the sense in the world: #14091 (comment)
from prometheus.
Related Issues (20)
- Documentation--default docker user is nobody HOT 1
- Why Does Prometheus Kubernetes Discovery Use a Single Informer 'process' Function and Queue? HOT 3
- Support exemplars with no labels HOT 2
- [Meta Issue] Created Timestamp Plan
- Created Timestamp: Store CT in per series metadata storage
- Created Timestamp: Use CT from metadata storage in PromQL engine
- Created Timestamp: Prometheus progates CT in Remote-Write 2.0
- insecure_skip_verify: true ignored
- Remote Write 2.0: Benchmarks vs 1.0 and OTLP HOT 1
- Remote Write 2.0: Write a blog post
- Problem with promtheus, cadvisor and node exporter in docker swarm with no Leader role node
- The password in the Prometheus configuration file needs to support encrypted storage. HOT 5
- "Label names with matchers" call returns "not found" during compaction
- Broken link in readme
- promql: sort_by_label should fallback to a consistent ordering by metric, not by sample value HOT 2
- There is a tag v2.52.1 with no release or Docker images HOT 7
- Add AWS Sigv4 support to scraper and http_sd HOT 2
- The issue of increased load due to Prometheus hot restart HOT 1
- Add unit testing for AWS SD HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prometheus.