Comments (8)
@haoranleo do you plan to work in this yourself? I think this would be a very welcome feature, but @roidelapluie has more context for sure.
from prometheus.
Hi @beorn7, yeah we can add the SigV4 support ourselves. Just wanted to seek opinions from upstream first and ensure there is no major concern of adding that support :D.
We are currently finalizing the discussion on exposing a native SigV4 enabled metrics endpoint, after it is finalized we can start working on the change.
from prometheus.
We chose not to implement this because users who only require http_sd shouldn't have to build the entire AWS dependencies. I'm curious if there are enough use cases to justify this approach, or if there's a way to enable AWS SigV4 at compile time specifically for http_sd and Alertmanager.
from prometheus.
With SigV4 supported by remote write, maybe we have already linked in most of the required dependencies?
from prometheus.
I personally have projects that are using only the discovery.
But I am fine either way, if there is an easy way to only have sigv4 with opt-in, let's do this. otherwise, let's bake it in...
from prometheus.
Inclusion/exclusion via build tags would be nice, I guess. (It could also be opt-out, so that users that care about binary size can exclude it, similar to what we do with SD mechanisms.)
from prometheus.
We chose not to implement this because users who only require http_sd shouldn't have to build the entire AWS dependencies.
If SigV4 support is added in the http_sd, user can still choose to opt out right? They can use other authentication methods same as today like basic_auth/oauth2/tls_config etc... Please correct me if I miss something
from prometheus.
I think @roidelapluie is talking about having all the library dependencies linked into the binary, even for those users that don't need SigV4 support.
from prometheus.
Related Issues (20)
- [Feature] Add new labels to time series
- Prometheus Mixin Dashboard: Prometheus/Overview Grafana Dashboard Using Deprecated Angular components HOT 2
- remote write 2.0 - decide how to handle no metadata found
- remote write 2.0 - decide whether addition of metadata should count towards max samples in write request
- remote write 2.0 - update write handler benchmarks for 2.0 format
- remote write 2.0 - DRY the queue manager code HOT 2
- feat: Move remote write receive to runtime reloadable config HOT 1
- [flaky test] TestEvaluations/testdata/native_histograms.test HOT 1
- ui (tests): Add tests for Native histogram helpers HOT 2
- remote write 2.0 - update `TestSampleDelivery` to check for metadata in 2.0 proto
- remote write 2.0 - update test for old samples filtering for 2.0
- @ modifier with future return inconsistent value for sum_over_time HOT 4
- Prometheus stucks on protection from Host Header Injection HOT 1
- SIGSEGV after writing block HOT 13
- Not enough memory resources HOT 2
- `navigator.clipboard` may not be available HOT 2
- Prometheus Staleness Issue on Fedora 39 HOT 1
- Prometheus reload not exist block: opening storage failed
- Metrics in "/actuator/prometheus" are not consistent in a multi nodes environment (kubernetes) HOT 1
- Recommendation for PGO with Prometheus HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prometheus.