Git Product home page Git Product logo

Comments (3)

machine424 avatar machine424 commented on June 18, 2024

I'm sure I ran 2.49.0 and prometheus had no problem scraping itself. Maybe the content negotiation implementation used by golang client is broken/doesn't follow the RFC? (accepts q>1?).

It can also be useful to have some e2e tests where we scrape real targets (not just httptest's where a lot of stuff is mocked) of different prom clients...

EDIT:

Yep, the implementation doesn't seem to check the quality value: https://github.com/prometheus/common/blob/773d5664eb8d228d2c6ba235b1af12fbf7ee9020/internal/bitbucket.org/ww/goautoneg/autoneg.go#L84

from prometheus.

hacklschorsch avatar hacklschorsch commented on June 18, 2024

I'm sure I ran 2.49.0 and prometheus had no problem scraping itself.

Yes, Prometheus seems to be rather lenient on what requests it accepts.
We also were still successfully scraping node-exporter, but not our own service's /metrics endpoint.

from prometheus.

machine424 avatar machine424 commented on June 18, 2024

Yep, all targets based on the golang client should have a "broken" content negotiation implementation, we'll probably need to fix that or move to another library: https://github.com/elnormous/contenttype seems to better stick to the RFC and seems to be better tested.

(having a standard implementation will be even better golang/go#19307)

from prometheus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.