Git Product home page Git Product logo

Comments (13)

gtorrezan avatar gtorrezan commented on July 25, 2024 1

When you enable debug logs and perform access with it, the file is generated.
Without opening the debug screen, the file is not generated

from samltoawsstskeys.

prolane avatar prolane commented on July 25, 2024

Hi @gtorrezan
Please check the errors in the logs. You can find instructions here: https://github.com/prolane/samltoawsstskeys#faq

from samltoawsstskeys.

sbol-coolblue avatar sbol-coolblue commented on July 25, 2024

It appears that the service worker goes inactive after some time. Any change made to the extension, for example disabling/enabling, awakens the service worker and re-enables the functionality.

I've enabled the debug log so that tomorrow, when this happens again, I'll hopefully have something useful to report.

from samltoawsstskeys.

hephbond avatar hephbond commented on July 25, 2024

I really wish this were fixed. I can confirm the behavior described in this issue. Without the debug window opened, it certainly does not download the credentials file.

from samltoawsstskeys.

prolane avatar prolane commented on July 25, 2024

@sbol-coolblue
Were you able to find anything?

@patricktalmeida has made a suggestion in PR #66 to add a sort of keep-alive. I'm wondering if there are any more experiences if this could be of help?

function keepServiceRunning() {
  // Call this function again in 5 minutes to keep service worker alive
  setTimeout(keepServiceRunning, 300000);
}


keepServiceRunning();

I'm planning to rollout a new release in the next few days based on 6283f58. I could add the keep-alive and hope this will fix the service worker getting inactive.

from samltoawsstskeys.

patricktalmeida avatar patricktalmeida commented on July 25, 2024

@prolane I tested it a few times, it seemed to have worked at first, but no, it's not working 😞

from samltoawsstskeys.

hephbond avatar hephbond commented on July 25, 2024

I found this post on StackOverflow which describes this issue and some possible options pretty well.

One thing I wanted to note for @patricktalmeida's keepServiceRunning() function was that:

The inactivity timer when no such requests or ports are open is even shorter: 30 seconds.

So maybe setTimeout(keepServiceRunning, 25000) would work?

If not, the "offscreen API" example looks promising.

from samltoawsstskeys.

prolane avatar prolane commented on July 25, 2024

@patricktalmeida Thanks for the heads up.

@hephbond Great, thanks for the link. There are certainly some suggestions to try. And indeed, perhaps the keep-alive every 20 seconds will do the job? I'll add this in the next release so we can see the effect.

Did you guys find a consistent way of reproducing the issue? I'm asking as I haven't been able to experience the issue myself. I'm using the extension to successfully get credentials at first. Then I'm just browsing other websites for 10 minutes. Afterwards I'm browsing to my IDP again to login to AWS. The extension still gets the credentials.

from samltoawsstskeys.

prolane avatar prolane commented on July 25, 2024

Yesterday I've released version 3.3. Hopefully the keep-alive like solution helps.

from samltoawsstskeys.

prolane avatar prolane commented on July 25, 2024

I'm not observing any stale service worker with 3.3. Not when I'm working for a few hours and then use the extension, nor do I see any issues when using the extension after the weekend for example.

Let me know if any of you do still see the issue. And if so, if there is any consist way you can reproduce the issue?

from samltoawsstskeys.

sbol-coolblue avatar sbol-coolblue commented on July 25, 2024

Hi Gerard - unfortunately I think I'm still seeing the issue happen. The workaround (disable extension, re-enable) has become muscle-memory by now, though so it might just be my mind playing tricks on me. I'll keep an eye out for it today.

It's a tricky one to find a reproduction case for, especially since the repro seems to depend on the passing of time, or some interaction with the laptop going into sleep/hibernation.

from samltoawsstskeys.

sbol-coolblue avatar sbol-coolblue commented on July 25, 2024

So far the issue has not appeared. Looks like the setTimeout() to keep the worker alive has indeed worked.

Thanks for the fix!

from samltoawsstskeys.

prolane avatar prolane commented on July 25, 2024

Awesome, thanks for the feedback @sbol-coolblue!

from samltoawsstskeys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.