Git Product home page Git Product logo

Comments (8)

prolane avatar prolane commented on July 25, 2024 1

With the refactoring of the code due to Chrome Extension manifest V3 there was indeed a bug introduced related to the sessionduration. I was able to reproduce the issue. You'll encounter this issue when your IDP does not add a Session Duration as one of the SAML Assertion attributes.

This is now fixed with this:

if (typeof sessionduration === 'undefined' || !ApplySessionDuration) {

I'll publish v3.2 tonight in the Chrome web store.

Please let me know if this indeed fixed it for you.

from samltoawsstskeys.

prolane avatar prolane commented on July 25, 2024

Hi @shubhkb
The line you are referring to is just the declaration of the variable.

Could you post the debug logs here?
See https://github.com/prolane/samltoawsstskeys#faq-frequently-asked-question for help.

from samltoawsstskeys.

mimol91 avatar mimol91 commented on July 25, 2024

@prolane
Screen Shot 2022-12-19 at 14 03 59

Screen Shot 2022-12-19 at 14 05 11

from samltoawsstskeys.

Bobatron avatar Bobatron commented on July 25, 2024

I have been having this same issue since last Friday:
image

Whilst this is being fixed, a workaround to getting the credentials file to downloaded is:

  1. View the extension settings via the 'Manage Extension' option
  2. Enable developer mode:
    image
  3. Inspect the service worker view:
    image
  4. From the console, set the value for sessionduration:
    image
  5. Connect to AWS and the credentials file should download as expected

from samltoawsstskeys.

shubhkb avatar shubhkb commented on July 25, 2024

Hi @shubhkb The line you are referring to is just the declaration of the variable.

Could you post the debug logs here? See https://github.com/prolane/samltoawsstskeys#faq-frequently-asked-question for help.

image

from samltoawsstskeys.

shubhkb avatar shubhkb commented on July 25, 2024

sessionduration

sessionduration This variable was not declared in onBeforeRequestEvent function to fix this you need to declare the variable.

from samltoawsstskeys.

prolane avatar prolane commented on July 25, 2024

@shubhkb I agree with you I should declare the variable in a next updated version and I will. For now I don't think it will make any functional difference, does it? The sessionduration variable will implicitly be a global variable due to:

sessionduration = attributes[i].AttributeValue['#text']

If your IDP does not include the SessionDuration Attribute, the sessionduration will be typeof 'undefined' as now checked on that line 143 where the error occurred.

if (typeof sessionduration === 'undefined' || !ApplySessionDuration) {

from samltoawsstskeys.

prolane avatar prolane commented on July 25, 2024

Closing this issue as this has been resolved and no new comments haven been left here.

from samltoawsstskeys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.