Git Product home page Git Product logo

Comments (1)

ztangent avatar ztangent commented on June 2, 2024

Seems like the issue is that we're hardcoding how the :continuous annotation gets parsed by the macro:

Gen.jl/src/inference/trace_translators.jl

Lines 182 to 194 in b959223

"""
@read(<source>, <annotation>)
Macro for reading the value of a random choice from an input trace in the [Trace Transform DSL](@ref).
<source> is of the form <trace>[<addr>] where <trace> is an input trace, and <annotation>
is either :discrete or :continuous.
"""
macro read(src, ann::QuoteNode)
return quote read($(esc(bij_state)), $(esc(src)), $(esc(typed(ann.value)))) end
end
"""

Gen.jl/src/inference/trace_translators.jl

Lines 169 to 180 in b959223

const DISCRETE = [:discrete, :disc]
const CONTINUOUS = [:continuous, :cont]
function typed(annotation::Symbol)
if annotation in DISCRETE
return DiscreteAnn()
elseif annotation in CONTINUOUS
return ContinuousAnn()
else
error("error")
end
end

The fixed definition would be something like:

macro read(src, ann)
    _typed = GlobalRef(Gen, :typed)
    return quote read($(esc(bij_state)), $(esc(src)), $(_typed)($(esc(ann.value)))) end
end

The downside is that it would lead to a somewhat slower dynamic call to the typed function at run-time, instead of handling that logic at compile time. I'm not sure how much slower, but perhaps it's worth not making the switch and just clearly documenting that the user has to directly specify whether they want something to be :continuous or :discrete.

from gen.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.