Consider the following simple programs <div class="snippet-clipboard-content notra

Related <a class="issue-link js-issue-link" data-error-text="Failed to load title" dat

This issue also seems highly related, but <a class="user-mention notranslate" data-hov

Error in `discard` returned by `update` for DynamicDSLTrace with hierarchical addresses about gen.jl HOT 3 OPEN

fsaad commented on June 2, 2024

Error in `discard` returned by `update` for DynamicDSLTrace with hierarchical addresses

from gen.jl.

Comments (3)

fsaad commented on June 2, 2024

Related #506

from gen.jl.

ztangent commented on June 2, 2024

Thanks for catching this!

So I'm trying to understand why the line of code you identified was introduced in the first place, and it looks like @alex-lew added it in this old commit: c8ce0d7

Apparently it was introduced to address cases where things were being discarded, but shouldn't be. So maybe we can check if the fix you suggested @fsaad also passes the original test case that @alex-lew added?

This is the test case:

Gen.jl/test/dsl/dynamic_dsl.jl

Lines 153 to 183 in 0570918

 # Addresses under the :data namespace will be visited, 

 # but nothing there will be discarded. 

 @gen function loopy() 

 a = @trace(normal(0, 1), :a) 

 for i=1:5 

 @trace(normal(a, 1), :data => i) 

 end 

 end 

 # Get an initial trace 

 constraints = choicemap() 

 constraints[:a] = 0 

 for i=1:5 

 constraints[:data => i] = 0 

 end 

 (trace,) = generate(loopy, (), constraints) 

 # Update a 

 constraints = choicemap() 

 constraints[:a] = 1 

 (new_trace, weight, retdiff, discard) = update(trace, 

 (), (), constraints) 

 # Test discard, score, weight, retdiff 

 @test get_value(discard, :a) == 0 

 prev_score = logpdf(normal, 0, 0, 1) * 6 

 expected_new_score = logpdf(normal, 1, 0, 1) + 5 * logpdf(normal, 0, 1, 1) 

 expected_weight = expected_new_score - prev_score 

 @test isapprox(expected_new_score, get_score(new_trace)) 

 @test isapprox(expected_weight, weight) 

 @test retdiff === UnknownChange()

from gen.jl.

ztangent commented on June 2, 2024

This issue also seems highly related, but @alex-lew identified a different line of code in add_unvisited_to_discard! as the likely culprit, so maybe it's a different issue?

#237

from gen.jl.

Recommend Projects

Error in `discard` returned by `update` for DynamicDSLTrace with hierarchical addresses about gen.jl HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	# Addresses under the :data namespace will be visited,
	# but nothing there will be discarded.
	@gen function loopy()
	a = @trace(normal(0, 1), :a)
	for i=1:5
	@trace(normal(a, 1), :data => i)
	end
	end

	# Get an initial trace
	constraints = choicemap()
	constraints[:a] = 0
	for i=1:5
	constraints[:data => i] = 0
	end
	(trace,) = generate(loopy, (), constraints)

	# Update a
	constraints = choicemap()
	constraints[:a] = 1
	(new_trace, weight, retdiff, discard) = update(trace,
	(), (), constraints)

	# Test discard, score, weight, retdiff
	@test get_value(discard, :a) == 0
	prev_score = logpdf(normal, 0, 0, 1) * 6
	expected_new_score = logpdf(normal, 1, 0, 1) + 5 * logpdf(normal, 0, 1, 1)
	expected_weight = expected_new_score - prev_score
	@test isapprox(expected_new_score, get_score(new_trace))
	@test isapprox(expected_weight, weight)
	@test retdiff === UnknownChange()