Git Product home page Git Product logo

alipay's People

Contributors

antho-girard avatar mathieuesteban avatar quetzacoalt91 avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

alipay's Issues

An error occured, please contact the merchant for more info.

Hello,

Basically we do not modify anything in the module, unlike another post that has.

But we still get this error...

Also, we realize the transaction status TRADE_CLOSED will lead to prestashop status "payment accepted"...which is incorrect.....

Unused files

Hi,

The following folders seem to be unused:

  • sql
  • upgrade

If you do not plan to add anything inside, I guess you can safely remove them.

Error on PrestaShop 1.4

When I try to configure the module, I get the wollowing error on PrestaShop 1.4:

Fatal error: Class 'AdminController' not found in /home/modules/www/public_html/prestashop-14/modules/alipay/alipay.php on line 164

service fees

is it possible to add an option to add service fees for final customer? as Alipay charge 3% for each transition...
BTW, small bug in css file of compatibility with some PS 1.6 version

Alipay does not support RMB currency

Hello,

Our website store http://cosmetigate.com/ has two(2) active currencies(HKD & CNY). We found out when our customer change the currency to HKD, they can use Alipay payment. However, if they want to use RMB currency, Alipay show an error message "Create a transaction error. Sorry, this listing does not support this currency , please buy other merchandise , thank you ! You may need to: return Alipay Home(Please see attached screen shot in the attachment). How can we solve this that we want our customer paying RMB?

1

Looking forward for your prompt response.

Thanks,

Marjun

Security review

incorrect payment confirmation

I have an issue on notify_url.php, the check here seems to be invalid :

https://github.com/PrestaShop/alipay/blob/master/notify_url.php#L58

$alipay_notify->getSign() will always return the same value of Tools::getValue('sign') because its value is affected here :
https://github.com/PrestaShop/alipay/blob/master/notify_url.php#L41
https://github.com/PrestaShop/alipay/blob/master/api/AlipayNotify.php#L405

I think the intented behavior is $alipay_notify->getSign() to compute the signature of $alipay_notify members and not to return $sign member affected from the intial request.

SQL security

https://github.com/PrestaShop/alipay/blob/master/alipay.php#L465 $id_order add (int) or intval()
https://github.com/PrestaShop/alipay/blob/master/alipay.php#L480 $id_order add (int) or intval()
https://github.com/PrestaShop/alipay/blob/master/api/AlipayNotify.php#L147 $this->notify_id $this->sign add pSQL()

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.