Comments (9)
This being caught depends on what @search
is and how it is set.
from brakeman.
rails 2? 3? using rails_xss?
from brakeman.
Using Rails 235, no rails_xss. Looking at https://github.com/nzkoz/rails_xss
the params hash gets passed into @search it is initialized from the following code:
class SearchForm < OpenStruct
attr_reader :params
def initialize(data, param_name, *args)
data ||= {}
contents = {}
@params = {}
args.each do |item|
contents[item] = data[item]
@params["#{param_name}[#{item}]"] = data[item]
end
super(contents)
end
end
from brakeman.
Do you have an example of it being set in a controller?
This is only going to be caught if it's something like
def all
@search = SearchForm.new(params, ...)
end
from brakeman.
Why will it only catch if called in a controller?
from brakeman.
Brakeman doesn't do whole program analysis (at least not at the moment, probably never since the Rails stack is huge), it looks at the regular Rails data flow from controllers to views, basically like a web request would do.
from brakeman.
so this is the controller action:
def index
params[:category] ||= default_category
@search = search_form(:s, :params => [ :category, :filter_type, :filter_value, :order, :advanced ])
and 'search_form' is a controller method defined as:
def search_form(param_name, opts = {})
SearchForm.new(params[param_name], param_name, *opts[:params])
end
from brakeman.
Okay. Brakeman is not going to look any further than @search = search_form(:s, :params => [ :category, :filter_type, :filter_value, :order, :advanced ])
(i.e., not into the body of search_form
). That's why this is not raising a warning.
It's a limitation of Brakeman at the moment (it doesn't really do inter-procedural analysis), but I'm thinking about supporting "simple" helper methods like this.
from brakeman.
Got it. Thanks.
from brakeman.
Related Issues (20)
- Brakeman does not follow directory symlinks HOT 7
- Brakeman hangs on some platforms HOT 5
- Brakeman unable to detect Renderables in a Gem? HOT 2
- Command Injection doesn't detect shellescape unless the code is in the same function HOT 2
- Undeliverable address [email protected] in LICENSE.md HOT 2
- Controller with "log" in pathname excluded from scan HOT 1
- Check Graphql end-point for vulnerabilities HOT 1
- with_content for ViewComponent flagged as dynamic render path HOT 4
- Parsing Error on splat operator
- Issue with adding autoload_paths for views dir HOT 1
- False negatives due to --skip-libs ignoring app/ files. HOT 2
- Support non-standard gemfile naming for dual booting Rails apps HOT 1
- brakeman still references haml 4 - which is a bit long in the tooth (Haml::Filter::Coffee class vs. module)
- Incorrect identification of User input; Unable to dynamically render fully qualified path HOT 1
- Command injection false positive HOT 2
- Does not identify Rails 8 applications
- `eval` call not being detected HOT 2
- Unvalidated `redirect_back` false negatives HOT 2
- Ability to include multiple brakeman.ignore files via cmd HOT 1
- False positive when passing a command array to Open3.pipeline
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brakeman.