Brakeman doesn't detect global solution to mass assignment about brakeman HOT 6 CLOSED

Hi, thanks for filing this issue.

There is already a check for this, so I am (somewhat) surprised it is not working.

I created a file as you described above. Brakeman detected it successfully and silenced the mass assignment warnings, so I am afraid I am unable to reproduce this behavior. Is this the exact code you have in that file?

from brakeman.

Yeah, that's an exact copy of the file. Let me investigate - the test I'm reporting on was actually run by someone else on my code; I didn't run it myself. She says she was using brakeman 0.5.1.

I'll give it a shot myself and get back to you.

Evan

On Jun 27, 2011, at 12:43 PM, presidentbeef wrote:

Hi, thanks for filing this issue.

There is already a check for this, so I am (somewhat) surprised it is not working.

I created a file as you described above. Brakeman detected it successfully and silenced the mass assignment warnings, so I am afraid I am unable to reproduce this behavior. Is this the exact code you have in that file?

Reply to this email directly or view it on GitHub:
#4 (comment)

from brakeman.

Can't reproduce...feel free to reopen if this happens again.

from brakeman.

Me too having this problem. I'm using:

brakeman 1.6.2
Rails 3.2.6
RVM 1.14.2
Ruby 1.9.3-p194

already have config.active_record.whitelist_attributes = true in application.rb.

No mass-assignment errors but I know there are many as I just added some attr_accessible to some models.

( I tried with both brakeman and brakmen -o brakeman.html )

Any thoughts?

from brakeman.

Hi,

I am afraid I do not understand the issue. Are you seeing mass assignment warnings?

If you have config.active_record.whitelist_attributes = true then you should not get any mass assignment warnings.

from brakeman.

Oopps, my bad! I want to see mass-assignment warnings. Changing config.active_record.whitelist_attributes to true does the job. Thanks and sorry for bothering you.

from brakeman.