Comments (6)
Yeah, it's ruby parser. I did some minor monkeypatching to help it out, but it's not enough. Hopefully there will be a release with 1.9 syntax support soon. I've considered vendoring it, but it seems like a pain.
On the other hand, I think it's silly that Rails will generate 1.9 syntax if you happen to use 1.9 and 1.8 syntax otherwise. Kind of a weird thing to do.
from brakeman.
Yeah that's like when you see a hash like:
asdf = {:something => 'asdf', asdf: 'something'} wtf
Justin wrote:
Yeah, it's ruby parser. I did some minor monkeypatching to help it
out, but it's not enough. Hopefully there will be a release with 1.9
syntax support soon. I've considered vendoring it, but it seems like a
pain.On the other hand, I think it's silly that Rails will generate 1.9
syntax if you happen to use 1.9 and 1.8 syntax otherwise. Kind of a
weird thing to do.
Reply to this email directly or view it on GitHub:
#20 (comment)
from brakeman.
Okay, I have a local copy of ruby_parser working with Brakeman, and it parses the Rails 3 generated files. Need to test some more to make sure I don't run into problems with the gem version.
Edit: I mean the ruby_parser gem will be installed because of dependencies that Brakeman has. I need to make sure the gem does not get loaded and cause conflicts with the local version.
from brakeman.
Okay, this should be all fixed now. Thanks!
from brakeman.
Confirmed. Thanks!
Justin wrote:
Okay, this should be all fixed now. Thanks!
Reply to this email directly or view it on GitHub:
#20 (comment)
from brakeman.
+1
from brakeman.
Related Issues (20)
- Error: undefined method `node_type' for nil:NilClass case value.node_type HOT 4
- False positive - loofah gem 2.19.1 is already beyond suggested upgrade of 2.2.1 HOT 2
- Config in environment files generated by external services are not detected HOT 1
- Documentation Missing for Path Traversal HOT 2
- `abbrev` warning for ruby 3.4.0 HOT 4
- Possibility to ignore/skip directories/paths HOT 4
- UnsafeReflection requires array to be defined with values strictly in the context of the execution HOT 4
- Brakeman does not follow directory symlinks HOT 7
- Brakeman hangs on some platforms HOT 5
- Brakeman unable to detect Renderables in a Gem? HOT 2
- Command Injection doesn't detect shellescape unless the code is in the same function HOT 2
- Undeliverable address [email protected] in LICENSE.md HOT 2
- Controller with "log" in pathname excluded from scan HOT 1
- Check Graphql end-point for vulnerabilities HOT 1
- with_content for ViewComponent flagged as dynamic render path HOT 4
- Parsing Error on splat operator
- Issue with adding autoload_paths for views dir HOT 1
- False negatives due to --skip-libs ignoring app/ files. HOT 2
- Support non-standard gemfile naming for dual booting Rails apps HOT 1
- brakeman still references haml 4 - which is a bit long in the tooth (Haml::Filter::Coffee class vs. module)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brakeman.